git commit question about wheel event became smooth since 1.102 to 1.103 version

[zxj5470]

❗ Please use the community forum for asking questions about how to use Cesium and best practices. The core Cesium team actively monitors the forum and we love seeing what people are working on! ❗

I found that the Globe wheel event has been smoothed since version 103.
I tried to find out which commit changed it.
But find commit 3d8f538 with 700+ files changed!

Should we add some commit constraints, for example, the number of file changes committed at a time should not be more than 100…...

It's so hard to find diff changes. @onsummer

[wewindy]

That commit is only jsdoc type changes

[zxj5470]

'@@ -136,3 +135,0 @@ function listenToWheel(aggregator, modifier) {',
'@@ -147,9 +143,0 @@ function listenToWheel(aggregator, modifier) {',
'@@ -157 +144,0 @@ function listenToWheel(aggregator, modifier) {',
'@@ -164,6 +151,8 @@ function listenToWheel(aggregator, modifier) {',
'@@ -372 +361 @@ Object.defineProperties(CameraEventAggregator.prototype, {',
'@@ -395 +384 @@ Object.defineProperties(CameraEventAggregator.prototype, {',
'@@ -413 +402 @@ CameraEventAggregator.prototype.isMoving = function (type, modifier) {',
'@@ -455 +444 @@ CameraEventAggregator.prototype.getLastMovement = function (type, modifier) {',
'@@ -549 +538 @@ CameraEventAggregator.prototype.reset = function () {',
'@@ -72 +71,0 @@ import WaterMaterial from "../Shaders/Materials/Water.js";',
'@@ -78 +77 @@ import WaterMaterial from "../Shaders/Materials/Water.js";',
'@@ -82,2 +81,2 @@ import WaterMaterial from "../Shaders/Materials/Water.js";',
'@@ -85 +84 @@ import WaterMaterial from "../Shaders/Materials/Water.js";',
'@@ -276 +274,0 @@ import WaterMaterial from "../Shaders/Materials/Water.js";',
'@@ -278,3 +276,3 @@ import WaterMaterial from "../Shaders/Materials/Water.js";',
'@@ -316,0 +315,2 @@ import WaterMaterial from "../Shaders/Materials/Water.js";',
'@@ -588,0 +589,4 @@ function getStructAssignments(fieldNames, values, struct, type) {',
'@@ -595,3 +598,0 @@ function getStructAssignments(fieldNames, values, struct, type) {',
'@@ -604,4 +605,4 @@ function getStructAssignments(fieldNames, values, struct, type) {',
'@@ -611 +612 @@ function getStructAssignments(fieldNames, values, struct, type) {',
'@@ -2165 +2164,0 @@ function zoom3D(controller, startPosition, movement) {',
'@@ -2191 +2190 @@ function zoom3D(controller, startPosition, movement) {',
'@@ -2906 +2905 @@ ScreenSpaceCameraController.prototype.update = function () {'

[zxj5470]

https://github.com/CesiumGS/cesium/blob/main/packages/engine/Source/Scene/CameraEventAggregator.js#L133-L173

[ggetz]

Hi @zxj5470. Is there a problem with 3d8f538 ?

Otherwise CHANGES.md is a good reference for finding relevant commits. In this case, the mouse wheel smoothing was changed in #11062.

[zxj5470]

It's so weird.

3d8f538 is committed at Feb 9 and
PR #11080 (Feb 19) has implemented mouse wheel smoothing.

and #11062 accepted #11080 (Feb 19) and add commits (Feb 21) and merged at (Feb 22).

So it's to blame git and JetBrains IDE 😢

[ggetz]

Huh, probably just something with the merge order. Thanks @zxj5470.