Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW-04 Feedback #1

Open
CassKon opened this issue Oct 16, 2017 · 1 comment
Open

HW-04 Feedback #1

CassKon opened this issue Oct 16, 2017 · 1 comment

Comments

@CassKon
Copy link

CassKon commented Oct 16, 2017

Hey!

I couldn't find your homework reading for grading issue but here is my feedback for homework 4:

General data reshaping and relationship to aggregation

  • Completed activity 2
  • Computed Life Expectancy for 4 countries total
  • Plotted Japanese vs Canadian LifeExp
  • Tables were all nicely formatted
  • Code had useful comments throughout and I like how you explained the structure of your comments (workflow vs coding) at the beginning!

Join, merge, look up

  • Created a new data frame with overlapping variables
  • Introduced a mistake to show how it impacts the use of joins
  • I like how you used a compound key for some of the join functions to demonstrate how the mistake introduced impacts the joins and data returned
  • Used inner_join, anti_join, left_join, full_join and semi_join

Potential improvements

  • Would have like you to change the order of the datasets in the join function to show how it changes the results

  • Did not try the merge() or match() functions

Overall really well done and I enjoyed reading!

@derekcho
Copy link

derekcho commented Dec 6, 2017

Hi @ChadFibke, here are some comments about your hw04:

  • For your first task, nice job showing the use of spread(). You are correct that the wide data frame allows you to more easily plot the life expectancies of Canada vs. Japan. For the second plot, it might have illustrated the point better if you had showed the amount of code required to produce the same plot using long form data. Nice plots though!
  • The second task was very well done! You did a very thorough job showing the effects of all kinds of joins. I don’t really have any criticisms for this task. You provided good examples as well as appropriate explanations to go along with them.
  • Overall your coding style was neat and efficient.
  • You should still have a README.md for each assignment that includes a progress report. I did not find one in your hw04 folder for this assignment.

Your grade will be emailed to you at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants