Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW05 ready for grading #2

Open
ChadFibke opened this issue Oct 20, 2017 · 3 comments
Open

HW05 ready for grading #2

ChadFibke opened this issue Oct 20, 2017 · 3 comments

Comments

@ChadFibke
Copy link
Owner

ChadFibke commented Oct 20, 2017

Thanks for taking a look!
@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho
@shadowforti @arthursunbao

The Main Repo

HW05.md

@arthursunbao
Copy link
Collaborator

Hi ChadFibke,

Nice to see your repo in an organized and beautiful way and congrats for finishing the STAT545 work!

The homework5 of yours has detailed information regarding factor management, plot visualization for different countries and I love your plot for the population size of distributions of America, which is very clear to show the growing tendency for all the countries in America with box plot. Furthermore, you implemented two plot types to help avoid too many countries in America for the plot, which is fantastic. Also, for the IO part, read_csv, write_csv is used, dput and dget is also used.

For visualization design, I think you can plot each dot into different colors so that it looks more visualized.

Finally, Writing figures is also included in a nice way.

Overall, I would give it a check plus for your hard work!

Regards
Jason

@shadowforti
Copy link

Hello

Well done for the last homework in STAT545

  • The folder is well organized and homework is easy to find.
  • Great job in showing factor levels and drop Oceania
  • Great job in reorder the factors with a nice plot
  • Great explanation and detailed steps in distinguish between "Arrange" and "Reorder"
  • Smooth importing and exporting files
  • Great visualization plot with population size matching dot size and clear labeling and indications of plots
  • Plot was successfully saved and posted
  • The coding is neat and clear
  • I really like your plots
  • All the tables are well illustrated
  • The homework folder is cleaned and reorganized

Some suggestions

  • Maybe include a Readme in the hw05 folder
  • Maybe have a comment section about where you found it challenging

Overall, the homework is great and I can see that you have mastered the contents.

Thanks

Jian

@derekcho
Copy link

Hi @ChadFibke, here are some comments about your hw05:

  • The first task was done correctly. You were able to successfully drop Oceania and its associated countries from gapminder
  • The reordering of factor levels was also well done. You showed the effects of only arrange and factor reordering on a plot and provided some good insight as well
  • Nice work with file I/O. Good explanations of the differences between write_csv and dput
  • For visualization design, you probably could have tried to add a few more features to your plot. Some of the plots used in previous sections actually had more elements.
  • Solid work overall. Your factor reordering section was very well done! Repo is clean and easy to navigate

Your grade will be emailed to you at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants