Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TrieDB to adopt a node level caching mechanism #4157

Closed
timwu20 opened this issue Sep 3, 2024 · 0 comments · Fixed by #4239
Closed

Update TrieDB to adopt a node level caching mechanism #4157

timwu20 opened this issue Sep 3, 2024 · 0 comments · Fixed by #4239
Assignees

Comments

@timwu20
Copy link
Contributor

timwu20 commented Sep 3, 2024

Issue summary

  • In parity's TrieDb they define a TrieCache that caches the in memory instantiated types for each node.
  • Our current cache.TrieCache interface only caches the bytes retrieved from storage and will require decoding into the Go node types.
  • I determined that we should update TrieDB to adopt the same node level caching strategy to achieve similar performance.
  • Implementation of this new TrieCache interface is actually done in substrate. Integration of the new TrieCache interface into TrieDB will be required.

Other information and links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant