Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Westend #22648256: invalid signature for precommit in grandpa justification #4190

Open
EclesioMeloJunior opened this issue Sep 19, 2024 · 0 comments
Labels
C-complex Complex changes across multiple modules. Possibly will require additional research. P-critical this must be fixed immediately or contributors or users will be severely impacted. S-grandpa issues related to block finality. S-sync-westend related to particular network syncing. T-bug this issue covers unexpected and/or wrong behaviour.
Milestone

Comments

@EclesioMeloJunior
Copy link
Member

Describe the bug

Gossamer could not successfully validate a Grandpa justification while following tip at block #22648256:

2024-09-19T17:57:20Z ERROR processing block #22648256 (0xb0d92d06e6dc1d078ee38ecced208803a869b4e6e31d6402bbb157a225bb31ff) failed: verifying justification: decoding and verifying justification: bad justification for header: invalid signature for precommit in grandpa justification pkg=sync

2024-09-19T17:57:20Z CRITICAL current sync strategy failed with: while handling ready block: verifying justification: decoding and verifying justification: bad justification for header: invalid signature for precommit in grandpa justification pkg=sync

2024-09-19T17:57:20Z INFO [FINISHED] worker 12D3KooWJifoDhCL3swAKt7MWhFb7wLRFD9oG33AL3nAathmU24x, request: BlockRequestMessage RequestedData=19 StartingBlock={22648251} Direction=0 Max=8 pkg=sync

2024-09-19T17:56:54Z INFO 🚣 currently syncing, 49 peers connected, finalized #22641152 (0xc1878bb1...490605cb), best #22648250 (0xc291e489...20beec70) pkg=sync

This issue is related and should be fixed once Gossamer starts to receive Commit messages from validators which mean that we will always have the highest finalized block, as we can see the highest finalized block is #22641152 which is not the highest finalized block of the network

Blocked by issue: #2931

@EclesioMeloJunior EclesioMeloJunior added T-bug this issue covers unexpected and/or wrong behaviour. C-complex Complex changes across multiple modules. Possibly will require additional research. P-critical this must be fixed immediately or contributors or users will be severely impacted. S-sync-westend related to particular network syncing. S-grandpa issues related to block finality. labels Sep 19, 2024
@P1sar P1sar added this to the Full Node MVP milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-complex Complex changes across multiple modules. Possibly will require additional research. P-critical this must be fixed immediately or contributors or users will be severely impacted. S-grandpa issues related to block finality. S-sync-westend related to particular network syncing. T-bug this issue covers unexpected and/or wrong behaviour.
Projects
None yet
Development

No branches or pull requests

2 participants