Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate more recent forks in oapi spec tests #6987

Open
2 tasks
nflaig opened this issue Jul 30, 2024 · 0 comments
Open
2 tasks

Activate more recent forks in oapi spec tests #6987

nflaig opened this issue Jul 30, 2024 · 0 comments
Labels
scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.

Comments

@nflaig
Copy link
Member

nflaig commented Jul 30, 2024

We should activate more recent forks in oapi spec tests after merging electra branch to unstable

const config = createChainForkConfig({...defaultChainConfig, ALTAIR_FORK_EPOCH: 1, BELLATRIX_FORK_EPOCH: 2});

While this is not critical it gives us better and more relevant test coverage. I have tried this in the past but there were issues in the beacon api spec (like wrong schemas) which should be resolved on the next release.

Same can be done for builder spec as well (although same issue with spec schemas).

Updates required for this are

  • schedule most recent fork in config (as fork is determined by slot in data)
  • update test data to use default values of most recent fork
@nflaig nflaig added the scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.
Projects
None yet
Development

No branches or pull requests

1 participant