Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review usage of initializeBeaconStateFromEth1 #7272

Open
philknows opened this issue Dec 2, 2024 · 1 comment
Open

Review usage of initializeBeaconStateFromEth1 #7272

philknows opened this issue Dec 2, 2024 · 1 comment
Labels
scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.

Comments

@philknows
Copy link
Member

Reference: ethereum/consensus-specs#4017

As described by @ensi321 , initialize_beacon_state_from_eth1 is being removed from spec. Review usage in Lodestar.

Currently is used in spec/presets/genesis.test.ts and initDevState()
@philknows philknows added the scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. label Dec 2, 2024
@philknows
Copy link
Member Author

Comment from @ensi321 :

Don't think we need to create state from eth1 to do all the tests. Maybe create a state from phase0, and use upgradeStateToX to get the desired state we want for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philknows