From 1bf3970d77ea04b3d6499036ec9aa41a81c4eba2 Mon Sep 17 00:00:00 2001 From: Julien Eluard Date: Wed, 14 Feb 2024 08:43:09 +0100 Subject: [PATCH 1/4] chore: fix prover README typos --- packages/prover/README.md | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/prover/README.md b/packages/prover/README.md index 290766219e79..5c4f7cfe5d32 100644 --- a/packages/prover/README.md +++ b/packages/prover/README.md @@ -7,8 +7,6 @@ > This package is part of [ChainSafe's Lodestar](https://lodestar.chainsafe.io) project -Typescript REST client for the [Ethereum Consensus API spec](https://github.com/ethereum/beacon-apis) - ## Usage You can use the `@lodestar/prover` in two ways, as a Web3 Provider and as proxy. For prover use case see below example. @@ -37,13 +35,12 @@ console.log({balance, address}); You can also invoke the package as binary. ```bash -npm -i g @lodestar/prover +npm i g @lodestar/prover lodestar-prover start \ --network sepolia \ - --execution-rpc https://lodestar-sepoliarpc.chainsafe.io \ - --mode rest \ - --beacon-rpc https://lodestar-sepolia.chainsafe.io \ + --execution-rpc-url https://lodestar-sepoliarpc.chainsafe.io \ + --beacon-urls https://lodestar-sepolia.chainsafe.io \ --port 8080 ``` From bb84333fd61da317dbc72234973a0d8166af9933 Mon Sep 17 00:00:00 2001 From: Julien Eluard Date: Wed, 14 Feb 2024 09:03:27 +0100 Subject: [PATCH 2/4] chore: fix typos --- packages/prover/src/cli/cmds/start/options.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/prover/src/cli/cmds/start/options.ts b/packages/prover/src/cli/cmds/start/options.ts index ac51aac3f17c..7d75648e3e8b 100644 --- a/packages/prover/src/cli/cmds/start/options.ts +++ b/packages/prover/src/cli/cmds/start/options.ts @@ -53,7 +53,7 @@ export const startOptions: CliCommandOptions = { }, beaconUrls: { - description: "The beacon node PRC urls for 'rest' mode.", + description: "The beacon node RPC urls for 'rest' mode.", type: "string", array: true, conflicts: ["beaconBootnodes"], @@ -61,7 +61,7 @@ export const startOptions: CliCommandOptions = { }, beaconBootnodes: { - description: "The beacon node PRC urls for 'p2p' mode.", + description: "The beacon node RPC urls for 'p2p' mode.", type: "string", array: true, conflicts: ["beaconUrls"], From 7ab5524fd4bb51ebc8b161db16eeb98086e4ede6 Mon Sep 17 00:00:00 2001 From: Julien Eluard Date: Wed, 14 Feb 2024 11:44:04 +0100 Subject: [PATCH 3/4] chore: address comments --- packages/prover/README.md | 8 +++++--- packages/prover/src/cli/cmds/start/options.ts | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/prover/README.md b/packages/prover/README.md index 5c4f7cfe5d32..61da32294b95 100644 --- a/packages/prover/README.md +++ b/packages/prover/README.md @@ -7,6 +7,8 @@ > This package is part of [ChainSafe's Lodestar](https://lodestar.chainsafe.io) project +A set of tools allowing to verify EL client JSON-RPC calls. + ## Usage You can use the `@lodestar/prover` in two ways, as a Web3 Provider and as proxy. For prover use case see below example. @@ -35,12 +37,12 @@ console.log({balance, address}); You can also invoke the package as binary. ```bash -npm i g @lodestar/prover +npm i -g @lodestar/prover lodestar-prover start \ --network sepolia \ - --execution-rpc-url https://lodestar-sepoliarpc.chainsafe.io \ - --beacon-urls https://lodestar-sepolia.chainsafe.io \ + --executionRpcUrl https://lodestar-sepoliarpc.chainsafe.io \ + --beaconUrls https://lodestar-sepolia.chainsafe.io \ --port 8080 ``` diff --git a/packages/prover/src/cli/cmds/start/options.ts b/packages/prover/src/cli/cmds/start/options.ts index 7d75648e3e8b..7f288afb3598 100644 --- a/packages/prover/src/cli/cmds/start/options.ts +++ b/packages/prover/src/cli/cmds/start/options.ts @@ -53,7 +53,7 @@ export const startOptions: CliCommandOptions = { }, beaconUrls: { - description: "The beacon node RPC urls for 'rest' mode.", + description: "Urls of the beacon nodes to connect to.", type: "string", array: true, conflicts: ["beaconBootnodes"], @@ -61,7 +61,7 @@ export const startOptions: CliCommandOptions = { }, beaconBootnodes: { - description: "The beacon node RPC urls for 'p2p' mode.", + description: "Urls of beacon bootnodes to connect to.", type: "string", array: true, conflicts: ["beaconUrls"], From 51feea71d1182ca2f6fa4bb34a2a18a2a6339dad Mon Sep 17 00:00:00 2001 From: Julien Eluard Date: Fri, 16 Feb 2024 13:24:02 +0100 Subject: [PATCH 4/4] chore: restore beaconBootnodes description --- packages/prover/src/cli/cmds/start/options.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/prover/src/cli/cmds/start/options.ts b/packages/prover/src/cli/cmds/start/options.ts index 7f288afb3598..af26f6c5ff3d 100644 --- a/packages/prover/src/cli/cmds/start/options.ts +++ b/packages/prover/src/cli/cmds/start/options.ts @@ -61,7 +61,7 @@ export const startOptions: CliCommandOptions = { }, beaconBootnodes: { - description: "Urls of beacon bootnodes to connect to.", + description: "The beacon node PRC urls for 'p2p' mode.", type: "string", array: true, conflicts: ["beaconUrls"],