Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace prefab requests #1107

Closed
Tracked by #1009
sneakzttv opened this issue Aug 23, 2024 · 4 comments
Closed
Tracked by #1009

Marketplace prefab requests #1107

sneakzttv opened this issue Aug 23, 2024 · 4 comments
Assignees
Labels
Type: Bug Added to issues and PRs if they are addressing a bug

Comments

@sneakzttv
Copy link
Contributor

System loads but is terribly slow and has a hanus amount of requests which is causing odd errors when minting.
Fields aren't populating properly. A fast connection seems fine, a slower connection seems to have issues.
I need to refactor the web requests so they're either batched or chat with the backend team to see if there is a more efficient call.

@sneakzttv sneakzttv added the Type: Bug Added to issues and PRs if they are addressing a bug label Aug 23, 2024
@sneakzttv sneakzttv self-assigned this Aug 23, 2024
@kantagara kantagara mentioned this issue Aug 26, 2024
59 tasks
@juans-chainsafe
Copy link
Contributor

This particular issue happens when you try to mint a NFT in a Collection that didn't get the Type. This is the error that appears when you try to mint:

Exception: Type not valid: 
ChainSafe.Gaming.Marketplace.MintCollectionNftManager.UploadNftImage () (at Assets/Samples/web3.unity SDK Marketplace/2.6.1/Marketplace Samples/Scripts/MintCollectionNftManager.cs:54)
ChainSafe.Gaming.Marketplace.EventManagerMarketplace.RaiseMintNftToCollection () (at Assets/Samples/web3.unity SDK Marketplace/2.6.1/Marketplace Samples/Scripts/EventManagerMarketplace.cs:171)
ChainSafe.Gaming.Marketplace.MarketplaceGUIManager.MintNftToCollection () (at Assets/Samples/web3.unity SDK Marketplace/2.6.1/Marketplace Samples/Scripts/MarketplaceGUIManager.cs:220)
UnityEngine.Events.InvokableCall.Invoke () (at /Users/bokken/build/output/unity/unity/Runtime/Export/UnityEvent/UnityEvent.cs:178)
UnityEngine.Events.UnityEvent.Invoke () (at /Users/bokken/build/output/unity/unity/artifacts/generated/UnityEvent/UnityEvent_0.cs:57)
UnityEngine.UI.Button.Press () (at ./Library/PackageCache/[email protected]/Runtime/UI/Core/Button.cs:70)
UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at ./Library/PackageCache/[email protected]/Runtime/UI/Core/Button.cs:114)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at ./Library/PackageCache/[email protected]/Runtime/EventSystem/ExecuteEvents.cs:57)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at ./Library/PackageCache/[email protected]/Runtime/EventSystem/ExecuteEvents.cs:272)
UnityEngine.EventSystems.EventSystem:Update() (at ./Library/PackageCache/[email protected]/Runtime/EventSystem/EventSystem.cs:530)

For some reason, some types are not populated in some of the collections.

@sneakzttv
Copy link
Contributor Author

Fixed by Nikola with #1135, PR merge will close this issue.

@sneakzttv sneakzttv linked a pull request Sep 16, 2024 that will close this issue
@sneakzttv
Copy link
Contributor Author

Closed in order to make the proper implementation that we already had in place. Moving this back to in progress for now.

@sneakzttv sneakzttv assigned kantagara and unassigned sneakzttv Sep 17, 2024
@kantagara
Copy link
Contributor

Marketplace samples are looking a bit different now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Added to issues and PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants