Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify DataStorage #976

Open
rob1997 opened this issue May 27, 2024 · 0 comments
Open

Unify DataStorage #976

rob1997 opened this issue May 27, 2024 · 0 comments
Assignees
Labels
Type: Enhancement Added to issues and PRs when a change includes improvements or optimizations. Type: Feature Added to issues and PRs to identify that the change is a new feature.

Comments

@rob1997
Copy link
Collaborator

rob1997 commented May 27, 2024

Summary
Currently we've only one DataStorage for Wallet Connect but we can save all data instances via one DataStorage.

Suggested features or ways to address the summary

  • We can have storable instances as and injectable IStorable with a StoragePath and LoadOnInitialize properties that can be used to save/load data on Web3 initialize.
  • We can have DataStorage as an injectable service that can save/load data.

Motivation

  • This will help us easily save and load data by just extending IStorable, will increase reusability, maintainability and readability of the codebase.

Acceptance Criteria

  • Instances can be saved and loaded just by extending IStorable
  • DataStorage will be responsible for saving, loading, deleting and resetting data

Blockers
(OPTIONAL) [Do you see any blocker that needs to be done before implementing this feature?]

Dependencies
(OPTIONAL) [Do you know about dependencies that directly affect this issue?]

Additional Context
(OPTIONAL) [Add any other context, files, images (screenshots/videos), diagrams, or documents about the feature request here.]

Final Steps

  • Give it one of these labels Type: Feature Type: Enhancement
  • Add your estimation

Estimations

| 3 | Mild efort | A day | Low complexity | Low |

@rob1997 rob1997 added Type: Enhancement Added to issues and PRs when a change includes improvements or optimizations. Type: Feature Added to issues and PRs to identify that the change is a new feature. labels May 27, 2024
@rob1997 rob1997 self-assigned this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Added to issues and PRs when a change includes improvements or optimizations. Type: Feature Added to issues and PRs to identify that the change is a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant