Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize project #11

Open
russplaysguitar opened this issue Oct 18, 2011 · 4 comments
Open

Re-organize project #11

russplaysguitar opened this issue Oct 18, 2011 · 4 comments
Labels

Comments

@russplaysguitar
Copy link
Member

Most of the code is within pyRunner.py, which is way too big. This StackOverflow page has some good info about organizing Python projects: http://stackoverflow.com/questions/391879/organising-my-python-project (note: 1 class per file is not the way to do it)

@ghost ghost assigned russplaysguitar Oct 19, 2011
@flipcoder
Copy link
Member

The project's over-usage of globals makes the code messy and hard to organize. Figuring out what to do with these would be a good next step to making the project cleaner.

@russplaysguitar
Copy link
Member Author

agreed

@rectangletangle
Copy link
Member

The Python global statement is supposed to be used sparingly if ever (it's useful in a few situations involving multithreading).

This thread has some good info on them.
http://stackoverflow.com/questions/146557/do-you-use-the-global-statement-in-python

@russplaysguitar
Copy link
Member Author

Here is what we had on the board on Tuesday:
PyRunner Reorganization

Each item is a class that should be put into a new file within the new /classes/ directory. The arrows indicate inheritance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants