Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400 items - Performance issues - Slow #816

Closed
alvarotrigo opened this issue Jan 28, 2020 · 4 comments · Fixed by #1170
Closed

400 items - Performance issues - Slow #816

alvarotrigo opened this issue Jan 28, 2020 · 4 comments · Fixed by #1170
Labels

Comments

@alvarotrigo
Copy link

Describe the bug

With a list of 400 issues I experiement performance issues when working with the single select box when:

  • Searching for a text
  • Clicking on an element (takes more than expected to hide the item)

To Reproduce
Go here: https://codepen.io/alvarotrigo/pen/PowgMmw
Search for a text such as "flkjadslkfjaslfjlakjf"
Or just click on any item in the list, you'll notice how it doesn't close as fast as expected.

Screenshots
See a video here:
video

Desktop (please complete the following information):

  • OS: latest Mac OS X Catalina 10.15.2
  • Browser Chrome
  • Version: lastest Chrome version 79.0
@alvarotrigo
Copy link
Author

alvarotrigo commented Jan 28, 2020

Just as a note.
The same list seems to work smoothly in Select2. So I assume the issue can be dealt with somehow.

@abarrak
Copy link

abarrak commented Feb 25, 2020

Still an issue in choicesJS @alvarotrigo ..
I wonder weather the root cause the highlight behavior and how to disable it ..

@Xon
Copy link
Collaborator

Xon commented Jul 28, 2024

This appears to be something todo with the css/html for the select-select mode. The multi-select works fine.

I actually prefer the multi-select UI even for single item, so I've hacked that into my own fork. The documentation (and config name) will need some cleanup.

@Xon
Copy link
Collaborator

Xon commented Aug 22, 2024

There was an O(N^2) behavior in search, since v11.0.0-rc8 was deployed it looks to be working better.

There is a stall when stopping search, but an that is because it is re-rendering all the choices

@Xon Xon linked a pull request Aug 22, 2024 that will close this issue
3 tasks
@Xon Xon closed this as completed in #1170 Aug 27, 2024
Anto59290 added a commit to betagouv/seves that referenced this issue Sep 27, 2024
Permet d'ajouter toutes les structures d'une fiche en tant que
destinataire et/ou copie en un seul clic.

Embarque une mise à jour de la bibliothèque pour bénéficier de
l'amélioration drastique des performances sur les listes longues (ce qui
est notre cas): Choices-js/Choices#816 .
Anto59290 added a commit to betagouv/seves that referenced this issue Sep 27, 2024
Permet d'ajouter toutes les structures d'une fiche en tant que
destinataire et/ou copie en un seul clic.

Embarque une mise à jour de la bibliothèque pour bénéficier de
l'amélioration drastique des performances sur les listes longues (ce qui
est notre cas): Choices-js/Choices#816 .

Un changement est réalisé dans la page d'ajout de contact car la
librairie ne supporte plus les listes de classes dans `classNames`.
Anto59290 added a commit to betagouv/seves that referenced this issue Oct 8, 2024
Permet d'ajouter toutes les structures d'une fiche en tant que
destinataire et/ou copie en un seul clic.

Embarque une mise à jour de la bibliothèque pour bénéficier de
l'amélioration drastique des performances sur les listes longues (ce qui
est notre cas): Choices-js/Choices#816 .

Un changement est réalisé dans la page d'ajout de contact car la
librairie ne supporte plus les listes de classes dans `classNames`.
Anto59290 added a commit to betagouv/seves that referenced this issue Oct 8, 2024
Permet d'ajouter toutes les structures d'une fiche en tant que
destinataire et/ou copie en un seul clic.

Embarque une mise à jour de la bibliothèque pour bénéficier de
l'amélioration drastique des performances sur les listes longues (ce qui
est notre cas): Choices-js/Choices#816 .

Un changement est réalisé dans la page d'ajout de contact car la
librairie ne supporte plus les listes de classes dans `classNames`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants