-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eraser shortcut #235
Comments
Good to know the drawing features are getting good use! :) Currently the eraser shortcut is the So the 2 options for this feature here are:
|
Thanks for the fast and friendly reply! I'm afraid Edit: Seems like the ubuntu package is awfully outdated. I have just built Pympress from source and now I see the eraser option. I am advocating for the first option (hold and erase). The reasons are two-fold:
I'd love to both show how much I appreciate the project and in what dire need I am of this feature with a donation. Is there any way to do that? I didn't find a link yet. |
There are no donations, see #216 for a discussion on that topic. In particular, maintaining pympress is a hobby and I intend to keep it that way − no matter how dire the need for new features is, sorry. I already started looking into this. Holding the shortcut is doable, though not in the conventional way for actions. The drawback is that it seems impossible to handle 2 distinct cases (so we should pick one):
|
Thanks for your answer! I very much understand and appreciate the way you go about things. I am not quite sure if I have understood you correctly; are things like "CTRL-e" possible if keys are only modifiers, or do you mean by only that "CTRL" is one, but "CTRL-x" is none for any x? I'm specifically asking about "CTRL-e" because the openboard-Eraser is bound to "CTRL-e", but its binding cannot be changed. This way, the eraser would work in both programs with the same button. One more thing that I suggest changing is this: Everytime you switch to a new slide, the highlight/annotations mode is toggled off again, so you have to activate it for every slide again. I think that the mode should only change if (1) you click on it again or (2) you chose another tool. |
CTRL-e would be a normal shortcut. Just CTRL would be a modifier-only. |
I understand. Then I would opt for the normal shortcut version, simply because most people who scribble on slides use a graphical pen anyhow (and there you can assign a shortcut to a button). This would also guarantee compatibility with OpenBoard. Those who you a mouse could then bind the eraser to a simple shortcut such as Ctrl-SPC. |
So both are implemented, either holding just a modifier (implicitly means modifier + click) or a normal shortcut (so you can set You can test by installing the current master. @Perangelot since you’re a highlight-tool “power user” you could also look through #68 see if some suggestions sound interesting to you. |
Thanks for the effort! I have pulled the latest changes and tried it out. Staying in highlight mode works perfectly! I still have not quite wrapped my head around how the eraser works, though: If I have set The behavior I am looking for is this: As long as you hold Sorry for the questions, but I have just started using github and do not know python :( Thanks for suggesting to have a look at #68. Once I find time, I'll definitely read through the suggestions :) |
The option you want to modify is |
I’ve renamed it |
Is your feature request related to a problem? Please describe.
When drawing with my tablet on the slides, it often happens that I want to erase certain lines. Simply undoing the last command won't do it. I have not found a way to do that and there does not seem to be a key defined for it.
Describe the solution you'd like
Create a shortcut for the erase function which is only called while the key the function is bound to is pressed. This way, I could bind one of my tablet buttons to that key in order to easily erase things.
Describe alternatives you've considered
The best alternative of course would be tablet support, but I think this is not worth the effort.
The text was updated successfully, but these errors were encountered: