Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronous version of validate() do not work as expected. #20

Open
istanishev opened this issue Jan 20, 2018 · 1 comment
Open

Synchronous version of validate() do not work as expected. #20

istanishev opened this issue Jan 20, 2018 · 1 comment
Labels
bug

Comments

@istanishev
Copy link
Collaborator

Internally, the synchronous (non-callback-based) version for validate() method is calling a callback based method but do not ensure the callback is called. This leads to unexpected behavior.
@istanishev istanishev added the bug label Jan 20, 2018
istanishev added a commit that referenced this issue Jan 22, 2018
@istanishev
Merge pull request #19 from istanishev/remove-callback
429d435 
Remove callback parameter as the function is completely synchronous (Issue #20)
@Giners
Copy link

Giners commented Apr 3, 2018

PR #19 closed this, right? Or is there something else going on that is unrelated to the changes in #19?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Giners @istanishev