You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this still wanted? I'd be able to take a shot at this. This package is great, but the mappings are due for some refactoring. There are now three locations to add formats. My last PR showed that this doesn't always go right.
Other things to take in consideration
Fix the returns: either
return strings from an enum
return true/false and throw for exceptional situations
split test data from formats so it isn't loaded in production
typescript maybe?
Also pinging @ozankaya because they seem to be in charge now
Yes, this refactoring is still required. Your list above looks good to me. Maybe we can skip TypeScript for now. We have declarations file for TypeScript support.
The text was updated successfully, but these errors were encountered: