Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path filtering not building when files deleted #99

Open
amerodeh-jg opened this issue Dec 4, 2023 · 0 comments
Open

Path filtering not building when files deleted #99

amerodeh-jg opened this issue Dec 4, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@amerodeh-jg
Copy link

Orb version:

1.0.0

What happened:

Hi all,
We started using the path filtering orb for one of our pipelines recently.

  - path-filtering/filter:
      name: check-updated-files
      mapping: |
        src/JG.Abc/.*    build-abc    true
        src/JG.Abc.Listener/.* build-abc-listener true
      base-revision: main
      config-path: .circleci/pipeline.yml

We have the above and it has been working fine but today we made a commit that removed 2 files.

src/JG.Abc/test.txt
src/JG.Abc.Listener/test.txt

And none of the pipelines ran when we pushed it. This feels like a bug?
More context:
A PR had 2 files (.txt) added by mistake. A commit deleted them. Following that commit, no pipeline ran. If our code relied on these 2 files being present and now they’re gone, the build would fail. This feels like a bug.

@amerodeh-jg amerodeh-jg added the bug Something isn't working label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant