Warnings in the Ansible tests

[y0rune]

Hello!
I tested the repo using the command:

ansible-lint --nocolor  >> to-be-improved.txt
cat to-be-improved.txt | grep -ioE 'tests\/integration\/.*:' | awk -F: '{print $1}' | sort -u

The output showed the Finished with 1808 failure(s), 681 warning(s) on 157 files.
I would like to check it and changed it to resolve all of them.

List where I would like to change the warnings:

• tests/integration/targets/meraki_action_batch/tasks/main.yml - Resolve warnings meraki action batch #368
• tests/integration/targets/meraki_admin/tasks/main.yml - Resolve warnings meraki admin #370
• tests/integration/targets/meraki_alert/tasks/main.yml - Resolve warnings meraki alert #371
• tests/integration/targets/meraki_config_template/tasks/main.yml - Resolve warnings meraki config template #372
• tests/integration/targets/meraki_device/tasks/main.yml - Resolve warnings meraki device #373
• tests/integration/targets/meraki_firewalled_services/tasks/tests.yml - Resolve warnings meraki firewalled services #374
• tests/integration/targets/meraki_management_interface/tasks/main.yml - Resolve warnings meraki management interface #375
• tests/integration/targets/meraki_mr_l3_firewall/tasks/main.yml - Resolve warnings in meraki mr l3 firewall #377
• tests/integration/targets/meraki_mr_radio/tasks/main.yml - Resolve warnings in meraki mr radio #378
• tests/integration/targets/meraki_mr_rf_profile/tasks/main.yml - Resolve warnings in meraki mr rf profile #383
• tests/integration/targets/meraki_mr_settings/tasks/main.yml - Resolved warnings in meraki_mr_settings #391
• tests/integration/targets/meraki_ms_access_list/tasks/tests.yml - Resolved warnings in meraki_ms_access_list #397
• tests/integration/targets/meraki_ms_stack/tasks/main.yml - Resolved warnings in meraki_ms_stack #402
• tests/integration/targets/meraki_ms_storm_control/tasks/main.yml - Resolved warnings in meraki_ms_storm_control #404
• tests/integration/targets/meraki_ssid/tasks/main.yml - Resolved warnings in meraki_ssid #396
• tests/integration/targets/meraki_ms_ospf/tasks/main.yml - Resolved warnings in meraki_ms_ospf #401
• tests/integration/targets/meraki_mx_intrusion_prevention/tasks/tests.yml - Resolved warnings in meraki_mx_intrusion_prevention #409
• tests/integration/targets/meraki_ms_switchport/tasks/main.yml - Resolved warnings in meraki_ms_switchport #405
• tests/integration/targets/meraki_mx_content_filtering/tasks/main.yml - Warnings in meraki_mx_content_filtering #406, meraki_mx_content_filtering - problem with restarting policy and idempotency #407, Trying resolving issue with meraki_mx_content_filtering #408
• tests/integration/targets/meraki_ms_l3_interface/tasks/main.yml - Resolved warnings in meraki_ms_l3_interface #398
• tests/integration/targets/meraki_ms_link_aggregation/meraki_network/tasks/main.yml - Resolved warnings in meraki_ms_link_aggregation #400
• tests/integration/targets/meraki_ms_link_aggregation/tasks/main.yml - Resolved warnings in meraki_ms_link_aggregation #400
• tests/integration/targets/meraki_ms_stack_l3_interface/tasks/main.yml - Resolved warnings in meraki_ms_stack_l3_interface #403
• tests/integration/targets/meraki_mx_l2_interface/tasks/main.yml - Resolved warnings in meraki_mx_l2_interface #432
• tests/integration/targets/meraki_mx_l3_firewall/tasks/main.yml - Resolved warnings in meraki_mx_l3_firewall #447
• tests/integration/targets/meraki_mx_l7_firewall/tasks/main.yml
• tests/integration/targets/meraki_mx_l7_firewall/tasks/tests.yml
• tests/integration/targets/meraki_mx_malware/tasks/main.yml
• tests/integration/targets/meraki_mx_nat/tasks/tests.yml
• tests/integration/targets/meraki_mx_network_vlan_settings/tasks/main.yml
• tests/integration/targets/meraki_mx_site_to_site_firewall/tasks/main.yml - meraki_mx_site_to_site_firewall - Sanity fixes #454
• tests/integration/targets/meraki_mx_site_to_site_vpn/tasks/main.yml
• tests/integration/targets/meraki_mx_static_route/meraki_static_route/tasks/main.yml
• tests/integration/targets/meraki_mx_third_party_vpn_peers/tasks/main.yml
• tests/integration/targets/meraki_mx_uplink_bandwidth/tasks/main.yml
• tests/integration/targets/meraki_mx_vlan/tasks/main.yml
• tests/integration/targets/meraki_network/tasks/main.yml
• tests/integration/targets/meraki_organization/tasks/main.yml - meraki_organization - Update organization tests for lint #458
• tests/integration/targets/meraki_organization/tasks/tests.yml - meraki_organization - Update organization tests for lint #458
• tests/integration/targets/meraki_snmp/tasks/main.yml - meraki_snmp - Fix formatting for linting #457
• tests/integration/targets/meraki_syslog/tasks/main.yml - meraki_syslog - Fix sanity errors #455
• tests/integration/targets/meraki_webhook/tasks/tests.yml - meraki_webhook - Add delegate_to for all tasks #456

Can you assign me to that task @kbreit?

Thank you!
Marcin

to-be-improved.txt

[kbreit]

You should be assigned to this issue.

[kbreit]

@y0rune I'd like to integrate the checks you're doing for these into CI. Would you send me the command you're running and I can add it? Thank you.