Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table striped data does not work in production build #188

Open
maxatdetroit opened this issue Mar 20, 2024 · 0 comments
Open

Table striped data does not work in production build #188

maxatdetroit opened this issue Mar 20, 2024 · 0 comments
Labels
bug Something isn't working prioritization-required This issue needs to be prioritized for future releases.

Comments

@maxatdetroit
Copy link
Member

maxatdetroit commented Mar 20, 2024

Describe the bug

When data-striped-row attribute is set on the cod-table element in the production build, the striping does not work.
314117674-dc12f868-1e84-4c5f-a539-719146e45036

This is most likely due to the same issue #134, since we can see that the attribute is not being propagated to children elements successfully:
image

We should also check if data-striped-col and data-col are working correctly in the production build.

To Reproduce

Steps to reproduce the behavior:

  1. Create a table element using the production build on a test site
  2. Set data-striped-row to "true"
  3. Observe that the table does not stripe its rows

Solution

We need to set the children attributes both on attribute change and in the slotchange callback as described in #134. We can use mixins introduced in #140 to do so.

@maxatdetroit maxatdetroit added bug Something isn't working prioritization-required This issue needs to be prioritized for future releases. labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prioritization-required This issue needs to be prioritized for future releases.
Projects
None yet
Development

No branches or pull requests

1 participant