Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support form labels for all form elements #241

Open
maxatdetroit opened this issue Jul 5, 2024 · 2 comments
Open

Support form labels for all form elements #241

maxatdetroit opened this issue Jul 5, 2024 · 2 comments

Comments

@maxatdetroit
Copy link
Member

maxatdetroit commented Jul 5, 2024

The Problem

Our checkboxes and radio buttons support setting labels using an element attribute, however our input and select elements do not. Additionally, all form elements should support setting labels using slots to enable custom markup if needed.

The Solution

@maxatdetroit
Copy link
Member Author

On second thought, we'll leave the label elements coupled with their respective form control in the design system. This seems to be a common paradigm in other popular design system and removes the burden on the design system user to correctly associate the label to the form element.

E.g. https://shoelace.style/components/input/

@maxatdetroit
Copy link
Member Author

Well, now that I'm looking at the design system, it looks like we're not consistent in how we approach labels. So this issue will be to bring consistency to our labels and form elements.

@maxatdetroit maxatdetroit reopened this Jul 5, 2024
@maxatdetroit maxatdetroit changed the title Decouple form elements Support form labels for all form elements Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant