Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Rename invokeFunction and testInvoke methods #13

Open
devhawk opened this issue Jan 7, 2022 · 4 comments
Open

Rename invokeFunction and testInvoke methods #13

devhawk opened this issue Jan 7, 2022 · 4 comments

Comments

@devhawk
Copy link

devhawk commented Jan 7, 2022

I'm guessing that the names testInvoke and invokeFunction are for back compat w/ older version of Neo and/or NEON wallet. But it's very confusing that invokeFunction wallet command is NOT the same as invokefunction RPC method.

Given that the wallet connect infrastructure is so new, is it possible to change the wallet methods to match the rpc method names?

@lllwvlvwlll
Copy link
Member

lllwvlvwlll commented Jan 11, 2022

The protocol methods were never intended to have a 1-1 mapping to rpc methods since there are features we want to expand which dont require node interfacing. This was a bit of an oversight. We are currently discussing how to handle this more cleanly and will most likely need to push the rpc methods down 1 level in the request payload format to accommodate this since the flat structure does not properly reflect this distinction.

@devhawk
Copy link
Author

devhawk commented Jan 11, 2022

For cases where there is no corollary like signMessage, that makes perfect sense. But it's very strange that invokeFunction wallet method != invokefunction RPC

@melanke
Copy link
Contributor

melanke commented Jun 10, 2022

I agree to change this method name, it is very different than a invokefunction RPC method and it will receive many upgrades to facilitate the usability, so, yea. What about publishInvoke? We could change it on beta branch (which is the future v2

@melanke melanke changed the title Wallet method names should match RPC method names Rename invokeFunction method Jun 10, 2022
@melanke melanke changed the title Rename invokeFunction method Rename invokeFunction and testInvoke methods Jun 10, 2022
@devhawk
Copy link
Author

devhawk commented Jun 10, 2022

I agree to change this method name, it is very different than a invokefunction RPC method and it will receive many upgrades to facilitate the usability, so, yea. What about publishInvoke? We could change it on beta branch (which is the future v2

Why not just match the RPC method name? The method currently called testInvoke would be called invokeScript and the method named invokeFunction would be sendRawTransaction.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants