Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cli values that might be interpreted as scientific notation #96

Open
dcernag opened this issue Jan 15, 2021 · 0 comments
Open

Handle cli values that might be interpreted as scientific notation #96

dcernag opened this issue Jan 15, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@dcernag
Copy link
Contributor

dcernag commented Jan 15, 2021

k8t CLI accepts json to be sent via --values to accommodate nested values. json.loads in util.load_cli_values would parse strings matching scientific notation to float even if it is a string.

This was first found when a 77950e8 commit sha sent as a CLI value was parsed as 7795000000000.0

See default decoding in https://docs.python.org/3/library/json.html#json-to-py-table

Temporary emergency fix added in #95 , we need to find a better way to handle them.

@dcernag dcernag added the bug Something isn't working label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant