Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to assign team reviewers? #142

Open
caleb15 opened this issue Mar 27, 2022 · 3 comments
Open

How to assign team reviewers? #142

caleb15 opened this issue Mar 27, 2022 · 3 comments
Labels

Comments

@caleb15
Copy link

caleb15 commented Mar 27, 2022

I tried assigning a an entire team as a reviewer when doing mp push but the PR had no reviewers. Is there a special syntax or something I need? Does microplane handle assigning a team as a reviewer? 🤔 I'm not sure if it's a bug or if I'm missing something.

mp push -a teamname -r eks_cicd-util
mp push -a 15five/teamname -b 'Testing multi-repo changes with https://github.com/Clever/microplane. You can ignore this.'

@nathanleiby
Copy link
Contributor

@caleb15 thanks for the report!

I tried assigning a an entire team as a reviewer when doing mp push but the PR had no reviewers. Is there a special syntax or something I need?
Does microplane handle assigning a team as a reviewer? 🤔 I'm not sure if it's a bug or if I'm missing something.

Today, microplane sets "assignees" but can't set "reviewers".

It seems Github doesn't support setting a team as an "assignee", although they do as a "reviewer". If of interest, here's some historical discussion on this feature suggestion: dear-github/dear-github#170

Given these two things, it unfortunately doesn't support your current workflow.

@nathanleiby
Copy link
Contributor

Solving this in microplane would require adding support for setting reviewers.

How assignees gets set today:

How reviewers could work:

  • Managing reviewers looks to now be available in Github's API https://docs.github.com/en/rest/reference/pulls#review-requests
  • Supporting it would require updating cmd/push.go (CLI interaction; add a new --reviewer flag) and push/push.go (Github API calls)
    • nit: could have >1 reviewer (or assignee) despite our support for just one today

@nathanleiby
Copy link
Contributor

One other thought: At Clever one workaround here is to use CODEOWNERS files, which ensure microplane created PRs get reviewers set automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants