Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade xml-crypto #216

Closed
toymachiner62 opened this issue Nov 6, 2020 · 11 comments
Closed

Upgrade xml-crypto #216

toymachiner62 opened this issue Nov 6, 2020 · 11 comments
Assignees

Comments

@toymachiner62
Copy link

toymachiner62 commented Nov 6, 2020

xml-crypto needs to be upgraded as there is a security vulnerability that is addressed in version 2.x https://snyk.io/vuln/SNYK-JS-XMLCRYPTO-1023301.

saml2 is using version ^0.10.0

@toymachiner62
Copy link
Author

#215 should resolve this.

@UjwalaK
Copy link

UjwalaK commented Nov 11, 2020

We have seen the same issue, the new version 2.0.6 of saml2-js uses xml-crypto of version 0.10.0 which has a security vulnerability as showed up in our scans. Forcing saml2-js to use xml-crypto of 2.0.0 didn't help.

Looking forward for an update where saml2-js will use new version of xml-crypto - 2.0.0 by default

@romain-as
Copy link

same issue for me, I can't manage to force xml-crypto 2.0.0

@jfaylon
Copy link

jfaylon commented Dec 9, 2020

Same issue for me. Please resolve ASAP.

@Himself132
Copy link

I would recommend that you take a look at the issue i documented here to see if this upgrade resolve the issue I also discovered when upgrading the library

#206

@jfaylon
Copy link

jfaylon commented Dec 11, 2020

https://www.npmjs.com/advisories/1583 it is a high vulnerability in the npm audit

@jfaylon
Copy link

jfaylon commented Jan 7, 2021

@mcab any update?

@AYUMIHNJ
Copy link

Same issue for me. Is there any update on this?

@hikino
Copy link

hikino commented Jan 19, 2021

I have the same issue.

@wadeperrigo
Copy link

Likewise, when will this be addressed. XML-Crypto v 2.0.0 has been out now for 4 months. How hard can it be to update the package.json file and test the functionality all still works wherever xml-crypto is loaded?

@mcab mcab self-assigned this Feb 3, 2021
@mcab
Copy link
Member

mcab commented Feb 4, 2021

#228 (based off of #215) addresses this.

Feel free to reopen if this is not the case.

@mcab mcab closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants