Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw Errors generated during attribute population #224

Open
mcab opened this issue Jan 26, 2021 · 0 comments
Open

Throw Errors generated during attribute population #224

mcab opened this issue Jan 26, 2021 · 0 comments

Comments

@mcab
Copy link
Member

mcab commented Jan 26, 2021

While the code in the current state is technically more correct (per the spec, <Subject> is an optional field, see below), it should probably be a SemVer-Major change to leave it in the current state.

From Page 19 of the spec:

2.4.1 Element
The optional element specifies the principal that is the subject of all of the (zero or more) statements in the assertion.

Originally posted by @aphix in #193 (comment)


If we choose to be more compliant with spec, we should throw errors rather than returning them. This should be facilitated with a major version change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant