Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib callback throws error which cannot be captured by caller #236

Open
zyf0330 opened this issue Jun 7, 2021 · 0 comments · May be fixed by #267
Open

zlib callback throws error which cannot be captured by caller #236

zyf0330 opened this issue Jun 7, 2021 · 0 comments · May be fixed by #267

Comments

@zyf0330
Copy link

zyf0330 commented Jun 7, 2021

Code is at

_(uri.query).extend sign_request(deflated.toString('base64'), @private_key, options.relay_state)

If pass empty string private_key to SP, this code will throw error but cannot be captured by caller, just by process.uncaughtException. I think it should be captured and pass into callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant