Changes the internal behavior of TimeVaryingInputs23D to use dates rather than seconds since start date #147
+365
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph-kev
changed the title
ph-kev
force-pushed
the
kp/dates
branch
6 times, most recently
from
85f2de7 to
fd40236
Compare
ph-kev
force-pushed
the
kp/dates
branch
3 times, most recently
from
799cde3 to
1f95510
Compare
|
I am running the nightly build locally on the main branch and it is stuck after finishing the DataStructures tests. I think it have to do something with NCDatasets.jl? |
Sbozzolo
reviewed
Jan 16, 2025
ext/TimeVaryingInputsExt.jl
Outdated
| TimeVaryingInputs.evaluate!( | ||
| dest, | ||
| itp, | ||
| Dates.Millisecond(round(Int64, 1000 * time)) + |
There was a problem hiding this comment.
I don't think so. I just got rid of it.
Sbozzolo
reviewed
Jan 16, 2025
TVI23D stands for TimeVaryingInput23D.
TVILPF stands for time varying inputs linear period filling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #146 - This commit changes the internal behavior of TimeVaryingInputs23D to use dates rather than seconds since start date. This will make the transition to ITime a little easier since it is easy to convert a ITime to a date.
The behavior of TimeVaryingInputs23D will only differ when
dtin milliseconds is an odd number or precision more than one millisecond is required. For the first case, this is because the code computesdt / 2in_time_range_dt_dt_e. In all other cases, the behavior should be identical as before.