Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3.3] Climate Card Issue #1058

Open
Th-Ar opened this issue Dec 18, 2024 · 9 comments
Open

[2.3.3] Climate Card Issue #1058

Th-Ar opened this issue Dec 18, 2024 · 9 comments
Assignees
@Clooos
Labels
bug Something isn't working Bug-Fix 🥳

Comments

@Th-Ar
Copy link

Th-Ar commented Dec 18, 2024 •
edited by MrBearPresident
Loading

There's a problem with climate maps concerning presets in sub-buttons. These do not update when they change.

Illustration :

Bubble.mp4
@Th-Ar Th-Ar added the bug Something isn't working label Dec 18, 2024
@Th-Ar Th-Ar changed the title [2.3.3] Climate Thermostat Issue [2.3.3] Climate Card Issue Dec 19, 2024
@Clooos
Copy link
Owner

Clooos commented Dec 20, 2024

Hi! I will take a look at this 👌

@Clooos
Copy link
Owner

Clooos commented Dec 22, 2024

Hi again! This issue should be fixed in the next release 🙂

@moafrancky moafrancky mentioned this issue Dec 28, 2024
Closed
@Th-Ar
Copy link
Author

Th-Ar commented Jan 1, 2025

Hello,
For information, I tried with the beta (2.3.4 beta 1), the problem is still present.
Bye

@Clooos
Copy link
Owner

Clooos commented Jan 1, 2025

Hi! Indeed I had to focus on the major issues introduced in the previous releases, but I will do my best to fix it soon 🙂

Clooos added a commit that referenced this issue Jan 14, 2025
@Clooos
More fixes for a stable v2.3.4
14ede92 
- [x] Added a grid-gap variable for pop-ups (Default is —bubble-pop-up-gap: 14px;)
- [x] Horizontal buttons stack unstable order #780 - PR #1137 by @RazorClam  
- [x] Select Card options show in default language instead of translation #1040
- [x] Select sub-button states are now correctly synched when changed elsewhere  #1058
- [x] Pop-up slide to close animation fixed
- [x] Reset popup auto-close timer on interaction with popup - PR #1071 by @samrenfrew
- [x] Add back the population of the context.cardtitle for the pop-ups to solve #1003 - PR #1089 by @MrBearPresident
- [x] Templates with card.querySelector('.bubble-state').innerText or card.querySelector('.bubble-name’).innerText are now instant when the page load
@Th-Ar
Copy link
Author

Th-Ar commented Jan 15, 2025

Hello,
Thanks for the new version 2.3.4., but the bug still present in this version. Normal ? (I'm not very familiar with how Github works ;) )

@Clooos
Copy link
Owner

Clooos commented Jan 15, 2025

Hi! This should be fixed, I've just tried again and this is working on my side. Have you cleared your browser/app cache? Sometime the old version stay in the cache.

@Th-Ar
Copy link
Author

Th-Ar commented Jan 15, 2025

Yes, i have cleared the browser cache. In Companion App i have the same behavior.
here's the video I just made :

Enregistrement.de.l.ecran.2025-01-15.133401.mp4

Thanks

@Clooos
Copy link
Owner

Clooos commented Jan 15, 2025

Well... I will try to reproduce this again 😅

@vrcdx64
Copy link

vrcdx64 commented Jan 24, 2025

Hi! Exactly same problem here. Don't hesitate if you want more informations or tests or my side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Clooos Clooos

Labels
bug Something isn't working Bug-Fix 🥳
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Th-Ar @Clooos @MrBearPresident @vrcdx64