Observations: Issues with RTL / Persian in v1.2.0

[YektaDev]

1. Number formatting. For some reason—even though it's mentioned that numbers are already being formatted—I’m seeing "1 نتیجه برای تست یافت شد" instead of "۱ نتیجه برای تست یافت شد". Am I missing something?

    console.log(new Intl.NumberFormat('fa').format(1)); // Returns ۱, the expected value

2. The buttons are incorrectly placed.
   As previously mentioned, the positions of the Search and Clear buttons need to be swapped in all RTL layouts, but this behavior doesn't seem to have been implemented yet.

[bglw]

👋 Thanks for the quick feedback!

Regarding the number formatting, can you provide a screenshot, or a link to a page exhibiting the issue? Here's the relevant code, where translations.language will be fa. Unsure what could be causing an issue here.

pagefind/pagefind_ui/default/svelte/ui.svelte

Lines 308 to 313 in 596a56e

	{translate("one_result", automatic_translations, translations)
	.replace(/\[SEARCH_TERM\]/, search_term)
	.replace(
	/\[COUNT\]/,
	new Intl.NumberFormat(translations.language).format(1)
	)}

Regarding the buttons — yes I didn't get that into the 1.2.0 release, but will make sure it's in the next release (1.2.1 or 1.3.0) along with any other feedback that is surfaced 🙂

[bglw]

Actually, I think I see the issue here. That check should also be looking at automatic_translations.language — I'll put a test case into the suite and get that fixed up.

[YektaDev]

Hi @bglw,

Just following up on the issues. The number formatting issue and the button placement in RTL layouts are still not fixed in v1.3.0.

Any updates on when these might be addressed?

Thanks!

[bglw]

Hi @YektaDev — thanks for checking in — I'll be doing a chunk of work on the UIs in January so I can make sure it is included in that.