From 7c2aaf2611cf0d902d86a03bac1523ceebbb7342 Mon Sep 17 00:00:00 2001 From: Petteri <26197131+PetteriM1@users.noreply.github.com> Date: Fri, 7 Jun 2024 23:18:44 +0300 Subject: [PATCH 1/3] Add simple scoreboard API --- src/main/java/cn/nukkit/Nukkit.java | 2 +- .../protocol/RemoveObjectivePacket.java | 27 ++ .../protocol/SetDisplayObjectivePacket.java | 36 ++ .../network/protocol/SetScorePacket.java | 118 ++++++ .../java/cn/nukkit/scoreboard/Scoreboard.java | 341 ++++++++++++++++++ 5 files changed, 523 insertions(+), 1 deletion(-) create mode 100644 src/main/java/cn/nukkit/network/protocol/RemoveObjectivePacket.java create mode 100644 src/main/java/cn/nukkit/network/protocol/SetDisplayObjectivePacket.java create mode 100644 src/main/java/cn/nukkit/network/protocol/SetScorePacket.java create mode 100644 src/main/java/cn/nukkit/scoreboard/Scoreboard.java diff --git a/src/main/java/cn/nukkit/Nukkit.java b/src/main/java/cn/nukkit/Nukkit.java index bf50d9187c7..c90a0e9665d 100644 --- a/src/main/java/cn/nukkit/Nukkit.java +++ b/src/main/java/cn/nukkit/Nukkit.java @@ -42,7 +42,7 @@ public class Nukkit { public final static Properties GIT_INFO = getGitInfo(); public final static String VERSION = getVersion(); - public final static String API_VERSION = "1.0.14"; + public final static String API_VERSION = "1.0.15"; public final static String CODENAME = ""; @Deprecated public final static String MINECRAFT_VERSION = ProtocolInfo.MINECRAFT_VERSION; diff --git a/src/main/java/cn/nukkit/network/protocol/RemoveObjectivePacket.java b/src/main/java/cn/nukkit/network/protocol/RemoveObjectivePacket.java new file mode 100644 index 00000000000..43dc9ead4a7 --- /dev/null +++ b/src/main/java/cn/nukkit/network/protocol/RemoveObjectivePacket.java @@ -0,0 +1,27 @@ +package cn.nukkit.network.protocol; + +import lombok.ToString; + +@ToString +public class RemoveObjectivePacket extends DataPacket { + + public static final byte NETWORK_ID = ProtocolInfo.REMOVE_OBJECTIVE_PACKET; + + public String objectiveId; + + @Override + public byte pid() { + return NETWORK_ID; + } + + @Override + public void decode() { + this.decodeUnsupported(); + } + + @Override + public void encode() { + this.reset(); + this.putString(this.objectiveId); + } +} \ No newline at end of file diff --git a/src/main/java/cn/nukkit/network/protocol/SetDisplayObjectivePacket.java b/src/main/java/cn/nukkit/network/protocol/SetDisplayObjectivePacket.java new file mode 100644 index 00000000000..37c10b7bf3f --- /dev/null +++ b/src/main/java/cn/nukkit/network/protocol/SetDisplayObjectivePacket.java @@ -0,0 +1,36 @@ +package cn.nukkit.network.protocol; + +import cn.nukkit.scoreboard.Scoreboard; +import lombok.ToString; + +@ToString +public class SetDisplayObjectivePacket extends DataPacket { + + public static final byte NETWORK_ID = ProtocolInfo.SET_DISPLAY_OBJECTIVE_PACKET; + + public Scoreboard.DisplaySlot displaySlot; + public String objectiveId; + public String displayName; + public String criteria; + public Scoreboard.SortOrder sortOrder; + + @Override + public byte pid() { + return NETWORK_ID; + } + + @Override + public void decode() { + this.decodeUnsupported(); + } + + @Override + public void encode() { + this.reset(); + this.putString(this.displaySlot.getType()); + this.putString(this.objectiveId); + this.putString(this.displayName); + this.putString(this.criteria); + this.putVarInt(this.sortOrder.ordinal()); + } +} diff --git a/src/main/java/cn/nukkit/network/protocol/SetScorePacket.java b/src/main/java/cn/nukkit/network/protocol/SetScorePacket.java new file mode 100644 index 00000000000..afa69855875 --- /dev/null +++ b/src/main/java/cn/nukkit/network/protocol/SetScorePacket.java @@ -0,0 +1,118 @@ +package cn.nukkit.network.protocol; + +import it.unimi.dsi.fastutil.objects.ObjectArrayList; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.ToString; + +import java.util.List; + +@ToString +public class SetScorePacket extends DataPacket { + + public static final byte NETWORK_ID = ProtocolInfo.SET_SCORE_PACKET; + + public Action action; + public final List infos = new ObjectArrayList<>(); + + @Override + public byte pid() { + return NETWORK_ID; + } + + @Override + public void decode() { + this.decodeUnsupported(); + } + + @Override + public void encode() { + this.reset(); + this.putByte((byte) this.action.ordinal()); + this.putUnsignedVarInt(this.infos.size()); + + for (ScoreInfo info : this.infos) { + this.putVarLong(info.scoreboardId); + this.putString(info.objectiveId); + this.putLInt(info.score); + + if (this.action == Action.SET) { + this.putByte((byte) info.type.ordinal()); + + switch (info.type) { + case PLAYER: + case ENTITY: + this.putEntityUniqueId(info.entityId); + break; + case FAKE: + this.putString(info.name); + break; + default: + throw new IllegalArgumentException("Invalid score info type"); + } + } + } + } + + public enum Action { + SET, + REMOVE + } + + @Getter + @EqualsAndHashCode + @ToString + public static class ScoreInfo { + + private final long scoreboardId; + private final String objectiveId; + private final int score; + private final ScorerType type; + private final String name; + private final long entityId; + + /** + * Score info for fake player + * @param scoreboardId + * @param objectiveId + * @param score score + * @param name line text + */ + public ScoreInfo(long scoreboardId, String objectiveId, int score, String name) { + this.scoreboardId = scoreboardId; + this.objectiveId = objectiveId; + this.score = score; + this.type = ScorerType.FAKE; + this.name = name; + this.entityId = -1; + } + + /** + * Score info for player/entity + * @param scoreboardId + * @param objectiveId + * @param type entity type; PLAYER or ENTITY + * @param score score + * @param entityId entity id + */ + public ScoreInfo(long scoreboardId, String objectiveId, int score, ScorerType type, long entityId) { + if (type != ScorerType.PLAYER && type != ScorerType.ENTITY) { + throw new IllegalArgumentException("Scorer type must be either PLAYER or ENTITY"); + } + + this.scoreboardId = scoreboardId; + this.objectiveId = objectiveId; + this.score = score; + this.type = type; + this.name = null; + this.entityId = entityId; + } + + public enum ScorerType { + INVALID, + PLAYER, + ENTITY, + FAKE + } + } +} diff --git a/src/main/java/cn/nukkit/scoreboard/Scoreboard.java b/src/main/java/cn/nukkit/scoreboard/Scoreboard.java new file mode 100644 index 00000000000..85e5cc8c2d5 --- /dev/null +++ b/src/main/java/cn/nukkit/scoreboard/Scoreboard.java @@ -0,0 +1,341 @@ +package cn.nukkit.scoreboard; + +import cn.nukkit.Player; +import cn.nukkit.Server; +import cn.nukkit.network.protocol.RemoveObjectivePacket; +import cn.nukkit.network.protocol.SetDisplayObjectivePacket; +import cn.nukkit.network.protocol.SetScorePacket; +import com.google.common.collect.ImmutableMap; +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.RequiredArgsConstructor; + +import java.util.*; +import java.util.concurrent.atomic.AtomicInteger; + +/** + * Simple API which handles the networking side of fake player scoreboards while + * leaving everything else to plugin developers + * + * @author PetteriM1 + */ +@RequiredArgsConstructor +public class Scoreboard { + + /** + * Used to generate unique identifiers for scoreboards + */ + private static final AtomicInteger SCOREBOARD_COUNT = new AtomicInteger(); + + /** + * Scoreboard scores sorting mode + */ + public enum SortOrder { + ASCENDING, + DESCENDING + } + + /** + * Scoreboard display location. Default is SIDEBAR. + */ + @Getter + @RequiredArgsConstructor + public enum DisplaySlot { + LIST("list"), + SIDEBAR("sidebar"), + BELOW_NAME("belowname"); + + private final String type; + } + + /** + * Scoreboard score which has a unique id and modifiable score value + */ + @AllArgsConstructor + public static class Score { + private final long id; + @Getter + private int score; + } + + /** + * Queued scoreboard score update + */ + @AllArgsConstructor + private static class QueuedScoreUpdate { + private final String scorer; + private final long currentScoreId; + private final int currentScoreValue; + private SetScorePacket.Action action; + } + + /** + * Players who can see the scoreboard. For internal use only, let plugin developers manage their scoreboards. + */ + private final Set viewers = new HashSet<>(); + + /** + * Scorers and their scores + */ + private final Map scores = new HashMap<>(); + + /** + * Scoreboard title + */ + private final String title; + + /** + * Order in which scorer names are sorted + */ + private final SortOrder sortOrder; + + /** + * Where the score is displayed + */ + private final DisplaySlot displaySlot; + + /** + * Unique identifier for the scoreboard + */ + private final String objectiveId = String.valueOf(SCOREBOARD_COUNT.getAndIncrement()); + + /** + * Counter for unique score identifiers + */ + private long scoreId; + + /** + * Weather automatic sending of updated scores is disabled + */ + private boolean isHoldingUpdates; + + /** + * Queued score updates when holdUpdates is true + */ + private final List queuedUpdates = new ArrayList<>(0); + + /** + * Update score for given scorer. + * @param scorer scorer name / line text + * @param newScore new score + * @return true if a score was changed or removed + */ + public boolean setScore(String scorer, int newScore) { + Score score = this.scores.get(scorer); + + if (score == null) { + score = new Score(++this.scoreId, newScore); + this.scores.put(scorer, score); + + this.sendScore(scorer, score, SetScorePacket.Action.SET); + } else if (score.score != newScore) { + score.score = newScore; + + this.sendScore(scorer, score, SetScorePacket.Action.SET); + + return true; + } + + return false; + } + + /** + * Remove score of given scorer. + * @param scorer scorer name / line text + * @return true if score did exist + */ + public boolean removeScore(String scorer) { + Score oldScore = this.scores.remove(scorer); + + if (oldScore != null) { + this.sendScore(scorer, oldScore, SetScorePacket.Action.REMOVE); + + return true; + } + + return false; + } + + /** + * Remove all scores and scorer names from the scoreboard. + * @return true if scores did exist + */ + public boolean clear() { + if (this.scores.isEmpty()) { + return false; + } + + this.sendClearPacket(); // Call this before clear so we know what to remove + + this.scores.clear(); + return true; + } + + /** + * Show the scoreboard to a player. Remember to call hideFor(player) when the player quits. + * @param player player + * @return true if player did not see the scoreboard already + */ + public boolean showTo(Player player) { + if (this.viewers.add(player)) { + this.sendShowPacket(player); + return true; + } + + return false; + } + + /** + * Hide the scoreboard for a player. + * @param player player + * @return true if player did see the scoreboard + */ + public boolean hideFor(Player player) { + if (this.viewers.remove(player)) { + if (!player.isClosed()) { + this.sendHidePacket(player); + } + return true; + } + + return false; + } + + /** + * Pause automatic sending of score updates to allow efficient bulk modifications. Queued updates are sent on unholdUpdates(). + * @return true if successful, false if already on hold + */ + public boolean holdUpdates() { + if (this.isHoldingUpdates) { + return false; + } + + this.isHoldingUpdates = true; + return true; + } + + /** + * Send all queued updates and continue sending updates automatically. + * @return true if successful, false if not on hold + */ + public boolean unholdUpdates() { + if (!this.isHoldingUpdates) { + return false; + } + + this.isHoldingUpdates = false; + + SetScorePacket pk = null; + SetScorePacket.Action lastAction = null; + + for (QueuedScoreUpdate update : this.queuedUpdates) { + if (update.action != lastAction) { + if (pk != null) { + Server.broadcastPacket(this.viewers, pk); + } + pk = new SetScorePacket(); + } + lastAction = update.action; + pk.action = update.action; + pk.infos.add(new SetScorePacket.ScoreInfo(update.currentScoreId, this.objectiveId, update.currentScoreValue, update.scorer)); + } + + if (pk != null) { + Server.broadcastPacket(this.viewers, pk); + } + + this.queuedUpdates.clear(); + return true; + } + + /** + * Returns unmodifiable view of internal scorers and scores. Plugin developers who are making their plugin to + * only display text can use this information to efficiently update only changed lines. + * @return unmodifiable map + */ + public Map getScores() { + return Collections.unmodifiableMap(this.scores); + } + + /** + * Send updated score to viewers. + * @param scorer scorer + * @param score score + * @param action set or remove + */ + private void sendScore(String scorer, Score score, SetScorePacket.Action action) { + if (this.viewers.isEmpty()) { + return; + } + + if (this.isHoldingUpdates) { + this.queuedUpdates.add(new QueuedScoreUpdate(scorer, score.id, score.score, action)); + return; + } + + SetScorePacket pk = new SetScorePacket(); + pk.action = action; + pk.infos.add(new SetScorePacket.ScoreInfo(score.id, this.objectiveId, score.score, scorer)); + Server.broadcastPacket(this.viewers, pk); + } + + /** + * Send cleared current scoreboard to viewers. + */ + private void sendClearPacket() { + if (this.viewers.isEmpty()) { + return; + } + + if (this.isHoldingUpdates) { + for (Map.Entry entry : this.scores.entrySet()) { + String scorer = entry.getKey(); + Score score = entry.getValue(); + this.queuedUpdates.add(new QueuedScoreUpdate(scorer, score.id, score.score, SetScorePacket.Action.REMOVE)); + } + return; + } + + SetScorePacket pk = new SetScorePacket(); + pk.action = SetScorePacket.Action.REMOVE; + for (Map.Entry entry : this.scores.entrySet()) { + String scorer = entry.getKey(); + Score score = entry.getValue(); + pk.infos.add(new SetScorePacket.ScoreInfo(score.id, this.objectiveId, score.score, scorer)); + } + Server.broadcastPacket(this.viewers, pk); + } + + /** + * Send scoreboard creation to the player + * @param player player + */ + private void sendShowPacket(Player player) { + SetDisplayObjectivePacket objectivePacket = new SetDisplayObjectivePacket(); + objectivePacket.displaySlot = this.displaySlot; + objectivePacket.objectiveId = this.objectiveId; + objectivePacket.displayName = this.title; + objectivePacket.criteria = "dummy"; + objectivePacket.sortOrder = this.sortOrder; + player.dataPacket(objectivePacket); + + SetScorePacket scorePacket = new SetScorePacket(); + scorePacket.action = SetScorePacket.Action.SET; + for (Map.Entry entry : this.scores.entrySet()) { + String scorer = entry.getKey(); + Score score = entry.getValue(); + scorePacket.infos.add(new SetScorePacket.ScoreInfo(score.id, this.objectiveId, score.score, scorer)); + } + player.dataPacket(scorePacket); + } + + /** + * Send scoreboard removal to the player + * @param player player + */ + private void sendHidePacket(Player player) { + RemoveObjectivePacket pk = new RemoveObjectivePacket(); + pk.objectiveId = this.objectiveId; + player.dataPacket(pk); + } +} From d8892ca111c84e721db0a0f9998ea84f35c20cda Mon Sep 17 00:00:00 2001 From: Petteri <26197131+PetteriM1@users.noreply.github.com> Date: Fri, 7 Jun 2024 23:30:09 +0300 Subject: [PATCH 2/3] Wrong branch --- .../java/cn/nukkit/network/protocol/RemoveObjectivePacket.java | 1 - .../cn/nukkit/network/protocol/SetDisplayObjectivePacket.java | 1 - src/main/java/cn/nukkit/network/protocol/SetScorePacket.java | 1 - 3 files changed, 3 deletions(-) diff --git a/src/main/java/cn/nukkit/network/protocol/RemoveObjectivePacket.java b/src/main/java/cn/nukkit/network/protocol/RemoveObjectivePacket.java index 43dc9ead4a7..6b7ceabb117 100644 --- a/src/main/java/cn/nukkit/network/protocol/RemoveObjectivePacket.java +++ b/src/main/java/cn/nukkit/network/protocol/RemoveObjectivePacket.java @@ -16,7 +16,6 @@ public byte pid() { @Override public void decode() { - this.decodeUnsupported(); } @Override diff --git a/src/main/java/cn/nukkit/network/protocol/SetDisplayObjectivePacket.java b/src/main/java/cn/nukkit/network/protocol/SetDisplayObjectivePacket.java index 37c10b7bf3f..9956751e9df 100644 --- a/src/main/java/cn/nukkit/network/protocol/SetDisplayObjectivePacket.java +++ b/src/main/java/cn/nukkit/network/protocol/SetDisplayObjectivePacket.java @@ -21,7 +21,6 @@ public byte pid() { @Override public void decode() { - this.decodeUnsupported(); } @Override diff --git a/src/main/java/cn/nukkit/network/protocol/SetScorePacket.java b/src/main/java/cn/nukkit/network/protocol/SetScorePacket.java index afa69855875..cf3fe6b6d9b 100644 --- a/src/main/java/cn/nukkit/network/protocol/SetScorePacket.java +++ b/src/main/java/cn/nukkit/network/protocol/SetScorePacket.java @@ -22,7 +22,6 @@ public byte pid() { @Override public void decode() { - this.decodeUnsupported(); } @Override From 0c696b10c829607181dc55817e04842061cd49fd Mon Sep 17 00:00:00 2001 From: Petteri <26197131+PetteriM1@users.noreply.github.com> Date: Fri, 7 Jun 2024 23:33:41 +0300 Subject: [PATCH 3/3] . --- src/main/java/cn/nukkit/network/protocol/ProtocolInfo.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/main/java/cn/nukkit/network/protocol/ProtocolInfo.java b/src/main/java/cn/nukkit/network/protocol/ProtocolInfo.java index f2c0c2bcf89..87a28030d5d 100644 --- a/src/main/java/cn/nukkit/network/protocol/ProtocolInfo.java +++ b/src/main/java/cn/nukkit/network/protocol/ProtocolInfo.java @@ -126,6 +126,11 @@ public interface ProtocolInfo { byte SERVER_SETTINGS_RESPONSE_PACKET = 0x67; byte SHOW_PROFILE_PACKET = 0x68; byte SET_DEFAULT_GAME_TYPE_PACKET = 0x69; + byte REMOVE_OBJECTIVE_PACKET = 0x6a; + byte SET_DISPLAY_OBJECTIVE_PACKET = 0x6b; + byte SET_SCORE_PACKET = 0x6c; + byte LAB_TABLE_PACKET = 0x6d; + byte UPDATE_BLOCK_SYNCED_PACKET = 0x6e; byte MOVE_ENTITY_DELTA_PACKET = 0x6f; byte SET_SCOREBOARD_IDENTITY_PACKET = 0x70; byte SET_LOCAL_PLAYER_AS_INITIALIZED_PACKET = 0x71;