Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging passwords? #436

Open
setharnold opened this issue Sep 23, 2021 · 2 comments
Open

logging passwords? #436

setharnold opened this issue Sep 23, 2021 · 2 comments

Comments

@setharnold
Copy link

logging.debug("Authorization: %s\n", auth_str)

Hello, this appears to log passwords when run with debug logging enabled. Quite often even debug logs don't include authentication credentials, so that administrators can be more confident in sharing logs with others.

Is this intentional and expected?

Thanks

@setharnold
Copy link
Author

cookie = authorize_and_get_cookie(options["--ip"], options["--username"], options["--password"], options)
also appears to be willing to log passwords.

@oalbrigt
Copy link
Collaborator

In fence_eps it's only when verbose logging is enabled (and also it's base64 encoded, so not in clear text either). fence_skalar also only does it with --verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants