Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't think MOVE_TASK code correct #26

Open
areve opened this issue Oct 31, 2021 · 0 comments
Open

I don't think MOVE_TASK code correct #26

areve opened this issue Oct 31, 2021 · 0 comments

Comments

@areve
Copy link

areve commented Oct 31, 2021

MOVE_TASK (state, { fromTasks, toTasks, fromTaskIndex, toTaskIndex }) {
const taskToMove = fromTasks.splice(fromTaskIndex, 1)[0]
toTasks.splice(toTaskIndex, 0, taskToMove)
},

This mutation doesn't affect the state at all, instead it modifies the arrays that are passed in as arguments. It works because the passed in values arrays happen to be the arrays from the store, but I don't think you're supposed to be modifying them directly.

Please discuss, I could be misunderstanding something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant