From 182441c64ccb130eaeef6f0fe5a24ff140fa2aac Mon Sep 17 00:00:00 2001 From: alejandroesoto Date: Tue, 17 Sep 2024 18:23:35 -0500 Subject: [PATCH] All bugs found and fixed, improved code also --- index.js | 34 ++++++++++++++++++++++++---------- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/index.js b/index.js index 4c2a94e..853b3c6 100644 --- a/index.js +++ b/index.js @@ -10,7 +10,7 @@ const correctMessage = document.getElementById('correct'); let targetNumber; let attempts = 0; -const maxNumberOfAttempts = 5; +let maxNumberOfAttempts = 5; // Returns a random number from min (inclusive) to max (exclusive) // Usage: @@ -25,10 +25,20 @@ function getRandomNumber(min, max) { function checkGuess() { // Get value from guess input element const guess = parseInt(guessInput.value, 10); - attempts = attempts + 1; - hideAllMessages(); + if (guess < 1) { + numberOfGuessesMessage.style.display = ''; + numberOfGuessesMessage.innerHTML = "You entered a number lower than 1, enter a number from 1 to 99."; + return; + } + if (guess > 99) { + numberOfGuessesMessage.style.display = ''; + numberOfGuessesMessage.innerHTML = "You entered a number higher than 99, enter a number from 1 to 99."; + return; + } + attempts = attempts + 1; + if (guess === targetNumber) { numberOfGuessesMessage.style.display = ''; numberOfGuessesMessage.innerHTML = `You made ${attempts} guesses`; @@ -43,16 +53,20 @@ function checkGuess() { if (guess < targetNumber) { tooLowMessage.style.display = ''; } else { - tooLowMessage.style.display = ''; + tooHighMessage.style.display = ''; } const remainingAttempts = maxNumberOfAttempts - attempts; numberOfGuessesMessage.style.display = ''; - numberOfGuessesMessage.innerHTML = `You guessed ${guess}.
${remainingAttempts} guesses remaining`; + if (remainingAttempts == 1) { + numberOfGuessesMessage.innerHTML = `You guessed ${guess}.
${remainingAttempts} guess remaining`; + } else { + numberOfGuessesMessage.innerHTML = `You guessed ${guess}.
${remainingAttempts} guesses remaining`; + } } - if (attempts ==== maxNumberOfAttempts) { + if (attempts == maxNumberOfAttempts) { submitButton.disabled = true; guessInput.disabled = true; } @@ -63,21 +77,21 @@ function checkGuess() { } function hideAllMessages() { - for (let elementIndex = 0; elementIndex <= messages.length; elementIndex++) { + for (let elementIndex = 0; elementIndex < messages.length; elementIndex++) { messages[elementIndex].style.display = 'none'; } } -funtion setup() { +function setup() { // Get random number targetNumber = getRandomNumber(1, 100); console.log(`target number: ${targetNumber}`); // Reset number of attempts - maxNumberOfAttempts = 0; + attempts = 0; // Enable the input and submit button - submitButton.disabeld = false; + submitButton.disabled = false; guessInput.disabled = false; hideAllMessages();