Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Ruler shows wrong line numbers when re-rendering #1008

Closed
Eliulm opened this issue Jan 20, 2023 · 3 comments · Fixed by #1509
Closed

🐞 Ruler shows wrong line numbers when re-rendering #1008

Eliulm opened this issue Jan 20, 2023 · 3 comments · Fixed by #1509
Labels
bug Something isn't working

Comments

@Eliulm
Copy link
Contributor

Eliulm commented Jan 20, 2023

Description

When first opening a file, the ruler displays the correct line numbering. However, when clicking on the textView again, the ruler gets re-rendered with the wrong line numbers:

Screen.Recording.2023-01-20.at.21.42.04.mov

To Reproduce

  1. Open any file in a small window instance, which causes multiple line breaks.
  2. Click at any point in the textView.

Expected behavior

The ruler should re-render with the correct line numbers.

Version information

macOS: 13.1
Xcode: 14.2

Additional context

No response
@Eliulm Eliulm added the bug Something isn't working label Jan 20, 2023
@ben-p-commits
Copy link
Contributor

It looks like it's doing some update due to text wrapping? hard to say...

@Eliulm
Copy link
Contributor Author

Eliulm commented Jan 23, 2023 •
edited
Loading

Yeah, there is a small shift of the line numbers happening, when it updates them on click.

@austincondiff
Copy link
Collaborator

This may be fixed with

@thecoolwinter thecoolwinter mentioned this issue Dec 13, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update To New Text View thecoolwinter/CodeEdit
3 participants
@austincondiff @ben-p-commits @Eliulm