Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Setting to toggle line number visibility #1020

Open
ben-p-commits opened this issue Jan 23, 2023 · 2 comments
Open

✨ Setting to toggle line number visibility #1020

ben-p-commits opened this issue Jan 23, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ben-p-commits
Copy link
Contributor

ben-p-commits commented Jan 23, 2023 •
edited by lukepistrol
Loading

Is your feature request related to a problem? Please describe.

This is the sibling issue to CETV's issue https://github.com/CodeEditApp/CodeEditTextView/issues/115 (Option To Hide Line Numbers). Line numbers should be an option that can be toggled, just like in Xcode.

Describe the solution you'd like

Line numbers should have a "Show:" boolean preference just like they do in Xcode.

There should be an accompanying palette command as well.

Describe alternatives you've considered

N/A- maintainers have voiced support for this approach in discussion under... https://github.com/CodeEditApp/CodeEditTextView/issues/115

Additional context

from Xcode

image
@ben-p-commits ben-p-commits added the enhancement New feature or request label Jan 23, 2023
@ben-p-commits
Copy link
Contributor Author

ben-p-commits commented Jan 23, 2023 •
edited
Loading

Adding this for posterity- I have implemented this change, and the supporting changes in CodeEditTextView are handled in https://github.com/CodeEditApp/CodeEditTextView/pull/124.

PR for CodeEdit is pending the next update to CETV.

@austincondiff austincondiff changed the title ✨ Add preference / palette command for hiding line numbers ✨ Add option for hiding line numbers Feb 16, 2023
@austincondiff austincondiff changed the title ✨ Add option for hiding line numbers ✨ Add option for hiding line numbers to Settings and Command Palette Feb 16, 2023
@austincondiff austincondiff changed the title ✨ Add option for hiding line numbers to Settings and Command Palette ✨ Setting to toggle line number visibility Feb 16, 2023
@austincondiff
Copy link
Collaborator

Update: PR #124 was closed and we are waiting on #127 until we can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
CodeEdit Project
Status: 🚧 Blocked
Milestone
No milestone
Development

No branches or pull requests
2 participants
@austincondiff @ben-p-commits