🐞 Sidebar animation is not smooth

[jacob-carlborg]

Description

The animation for hiding and showing the sidebars is not smooth. It applies to both the left and the right sidebar (inspector). It seems to be related to the size of the currently opened document. If no document is open, it's smooth. If a large document is opened the animation is not smooth. The larger document, the less smooth the animation is. It's enough with a document of 240 lines to notice a difference. If the document is over 1000 lines it's clearly visible. See attached video which shows the problem when a document with slight more than 1000 lines is open:

codeedit_sidebar.mov

To Reproduce

1. Open a project
2. Open a large document (1000 lines or more)
3. Click the show/hide button for the inspector pane/right sidebar

Expected behavior

I expect the animation to be as smooth as in Xcode. See attached video for how it looks like in Xcode:

xcode_sidebar.mov

Version information

CodeEdit: 0.0.1-alpha (25)
macOS: 13.0.1 (22A400)

Additional context

No response

[matthijseikelenboom]

@thecoolwinter I suspect this has to do with this CodeEditTextView issue. What do you think?

[thecoolwinter]

Most likely, it's a known issue with the ruler view being very inefficient for resizes as it redraws every line number every update.

[austincondiff]

Would this be solved when we implement our own ruler view then via https://github.com/CodeEditApp/CodeEditTextView/issues/127?

[thecoolwinter]

It should be, also related is CodeEdit/CodeEditTextView#131 .

[thecoolwinter]

Actually, it looks like Marcin did a bunch of work on STTextView recently, this might be fixed with CodeEditApp/CodeEditTextView#138.

[thecoolwinter]

Yep! Fixed in the previously mentioned PR.