Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Selected Line Background Extends Outside Text #59

Closed
thecoolwinter opened this issue Nov 23, 2024 · 1 comment
Closed

🐞 Selected Line Background Extends Outside Text #59

thecoolwinter opened this issue Nov 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@thecoolwinter
Copy link
Contributor

Description

The selected line background extends outside the region text is drawn in.

To Reproduce

  • Open a file
  • Add some or trailing padding.
  • Select 3 or more lines
  • Notice that the background is drawn as far left as possible.

Expected Behavior

The background should be drawn inside the bounds set by the text view's padding.

Version Information

CodeEditTextView: 0.7.7
macOS: 15.1
Xcode: 16.1

Additional Context

No response

Screenshots

Screenshot 2024-11-22 at 9 36 17 PM
@thecoolwinter thecoolwinter added the bug Something isn't working label Nov 23, 2024
@thecoolwinter thecoolwinter mentioned this issue Nov 24, 2024
Merged
6 tasks
thecoolwinter added a commit that referenced this issue Jan 10, 2025
@thecoolwinter
Inset Selection Rect By Edge Insets (#60)
41ea36f 
### Description

Insets the drawn selection box by the text view's edge insets. 

### Related Issues

* #59 

### Checklist

<!--- Add things that are not yet implemented above -->

- [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code

### Screenshots


https://github.com/user-attachments/assets/74f8a8bd-4467-4b65-b068-96544c230dad
@thecoolwinter
Copy link
Contributor Author

Closed with #60

@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Complete in CodeEdit Project Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thecoolwinter