Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research removing /people from site #55

Open
machow opened this issue Feb 2, 2022 · 2 comments
Open

Research removing /people from site #55

machow opened this issue Feb 2, 2022 · 2 comments
Assignees

Comments

@machow
Copy link
Contributor

machow commented Feb 2, 2022

From discussion with leadership (e.g. @mariekers , Kat, and Julia), it sounds like people are on board with removing /people.

  • What are the steps needed?
  • Are there surprising issues that arise (e.g. can people still edit their profiles? create projects?)
@tblacknc
Copy link
Collaborator

tblacknc commented Feb 2, 2022

This looks easily done by putting a redirect in the people.php file:

<?php

Site::redirectPermanent("/", $_GET);

And removing the 2 links in the header.

Editing your profile is in the /profile directory and creating/editing projects in the /projects directory and are verified not to be effected.

@tblacknc
Copy link
Collaborator

tblacknc commented Feb 3, 2022

Did this in 2 PRs, I am sure there is a way to do it in 1 but it wasn't jumping out at me:

Removal of link:
http://pr-57.codeforphilly.sandbox.k8s.phl.io/

redirect:
http://pr-58.codeforphilly.sandbox.k8s.phl.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants