Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship with an empty public folder, rather than intermixing build and git-tracked assets #224

Open
pwolanin opened this issue Apr 11, 2022 · 0 comments

Comments

@pwolanin
Copy link
Collaborator

Since we moved to a github pages deploy, it would make things easier to understand if the target "public" folder had no assets tracked in git (i.e. was git ignored) and all the assets under git control were in more clearly documented locations.

To make this work, we basically need to add to webpack a step to copy those assets to the public folder using something like the copy-webpack-plugin. Looks like we'd have to use something like v 4.6.0 with the current outdated node version used to build

https://v4.webpack.js.org/plugins/copy-webpack-plugin/
https://github.com/webpack-contrib/copy-webpack-plugin/tree/v4.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant