Traack remove local storage code #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
avenmia
commented
Jul 24, 2023
•
avenmia
commented
- Removes the local storage checks
- Removes the XID column and uses the user ID instead
- The polis survey only renders when the user ID is returned from the database
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
dinoboy197
reviewed
Jul 25, 2023
| document.body.removeChild(script); | ||
| }; | ||
| }, []); | ||
| if (userID === "" || userID === undefined) { |
There was a problem hiding this comment.
Is it possible for this page to load if the user hasn't logged in yet?
If yes, then I propose that if we detect that the userID isn't in the session that we redirect the user back to the home page instead of just saying Loading Surveys. What do you think?
There was a problem hiding this comment.
I believe we want to redirect the user back to the home page if they're not logged in for all pages, but I'll add that in a separate PR
dinoboy197
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.