Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local development instructions to run fully containerized for dev consistency #216

Merged
merged 4 commits into from
Aug 25, 2024

Conversation

dinoboy197
Copy link
Contributor

Each developer's workstation is set up differently. Because of this, there can be variability in how the local environment may run (or not run) HIERR due to different shared libraries or other dependencies being installed (or not installed).

This PR fully containerizes the HIERR app when run locally, ensuring complete consistency when developing.

@dinoboy197 dinoboy197 requested a review from a team as a code owner July 17, 2024 04:07
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hierr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 0:20am

Copy link
Collaborator

@avenmia avenmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dinoboy197
Copy link
Contributor Author

@avenmia I can't merge this as the repo branch protection rules are configured to require a build with Node 16.x, and your PR here removed the Node 16.x build.

If you give me repo admin, I can remove the requirement to have a Node 16.x build pass (and replace it with a Node 20.x) build. Once that I happens, I'll trigger a rebuild of this branch and I can merge.

@avenmia
Copy link
Collaborator

avenmia commented Aug 25, 2024

@avenmia I can't merge this as the repo branch protection rules are configured to require a build with Node 16.x, and your PR here removed the Node 16.x build.

If you give me repo admin, I can remove the requirement to have a Node 16.x build pass (and replace it with a Node 20.x) build. Once that I happens, I'll trigger a rebuild of this branch and I can merge.

@dinoboy197 Should be fixed 👍

@avenmia avenmia marked this pull request as draft August 25, 2024 00:59
@avenmia avenmia marked this pull request as ready for review August 25, 2024 00:59
@dinoboy197 dinoboy197 merged commit bb7ec8a into main Aug 25, 2024
4 checks passed
@dinoboy197
Copy link
Contributor Author

@dinoboy197 Should be fixed 👍

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants