Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WP 6.3] Deprecated function notice on single product pages #4051

Closed
irinelenache opened this issue Jul 28, 2023 · 2 comments
Closed

[WP 6.3] Deprecated function notice on single product pages #4051

irinelenache opened this issue Jul 28, 2023 · 2 comments
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. tiny (1h) - This label is used for issues that can be completed in under an hour.

Comments

@irinelenache
Copy link
Contributor

Description

On single product pages, there are notices about some deprecated function, using WP 6.3 RC2 https://vertis.d.pr/i/fpVnYt
Deprecated: Function WP_Scripts::print_inline_script is deprecated since version 6.3.0! Use WP_Scripts::get_inline_script_data() or WP_Scripts::get_inline_script_tag() instead. in /home/bosukofuku1686/web/ppom-wp63.vertisite.cloud/public_html/wp-includes/functions.php on line 5453

Step-by-step reproduction instructions

  1. Import a shop demosite
  2. Update WordPress to version 6.3 RC2
  3. Check a single product page

Screenshots, screen recording, code snippet or Help Scout ticket

https://vertis.d.pr/i/fpVnYt

Environment info

Neve 3.6.5 / WooCommerce 7.9 / WordPress 6.3 RC2

Is the issue you are reporting a regression

No

@irinelenache irinelenache added the bug This label could be used to identify issues that are caused by a defect in the product. label Jul 28, 2023
@cristian-ungureanu cristian-ungureanu added the tiny (1h) - This label is used for issues that can be completed in under an hour. label Aug 2, 2023
@cristian-ungureanu
Copy link
Contributor

Hey @irinelenache, we don't use WP_Scripts::print_inline_script anywhere inside Neve or Neve Pro. I saw you were using WooCommerce which I think is where the problem occurs.
Found this ticket on the WordPress support forum and this one on GitHub. The one on GitHub was closed five days ago, on the day you opened this ticket. The problem should be fixed in their new version which is not out yet.

There's not much to do here, we can either close the ticket or wait for WooCommerce 7.9.1 version and close it after we test again.

cc. @HardeepAsrani

@irinelenache
Copy link
Contributor Author

@cristian-ungureanu Thank you for the research 🚀 I tested using WooCommerce 8.0 RC1 and the notices are gone ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Projects
None yet
Development

No branches or pull requests

2 participants