Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer broken with WP 5.4 #4068

Closed
irinelenache opened this issue Aug 10, 2023 · 3 comments · Fixed by #4075
Closed

Customizer broken with WP 5.4 #4068

irinelenache opened this issue Aug 10, 2023 · 3 comments · Fixed by #4075
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.

Comments

@irinelenache
Copy link
Contributor

Description

The customizer is broken using WordPress 5.4 and some errors are thrown in console https://vertis.d.pr/i/eIKwgW . On wp.org the minimum supported WordPress version is 5.4, so we can either fix the bug or raise the min version. There are no other problems with version 5.5 or higher ✅

Step-by-step reproduction instructions

  1. Install wordpress 5.4
  2. Open the customizer

Screenshots, screen recording, code snippet or Help Scout ticket

https://vertis.d.pr/i/eIKwgW

Environment info

Neve 3.6.6 / WordPress 5.4 / PHP 7.4

Is the issue you are reporting a regression

No

@irinelenache irinelenache added the bug This label could be used to identify issues that are caused by a defect in the product. label Aug 10, 2023
@HardeepAsrani
Copy link
Member

@vytisbulkevicius Here I'd consider dropping support for WordPress 5.4 as it's 3 years old and only has 2.1% usage: https://wordpress.org/about/stats/

Let me know what you think.

@vytisbulkevicius
Copy link
Contributor

Hey @HardeepAsrani.

I don't see users who would have reported this issue, so I agree that we can increase the version support to 5.5.

@cristian-ungureanu cristian-ungureanu added the tiny (1h) - This label is used for issues that can be completed in under an hour. label Aug 16, 2023
@cristian-ungureanu cristian-ungureanu linked a pull request Aug 17, 2023 that will close this issue
6 tasks
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.6.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants