Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added scroll to top cta #4202

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

preda-bogdan
Copy link
Contributor

@preda-bogdan preda-bogdan commented Feb 6, 2024

Summary

Added new upsell control for Scroll To Top CTA.

Will affect the visual aspect of the product

YES/NO

Screenshots

Neve Free Scroll To Top Upsell

image

Test instructions

  1. On a fresh instance of Neve w/o. Neve Pro
  2. Check that inside the Customizer on Layout > Scroll To Top the upsell is present, with disabled controls, and the upsell link works.
  3. Check that after activating Neve Pro the upsell is no longer present and the module is available as before.

Check before Pull Request is ready:

Closes Codeinwp/neve-pro-addon#2734.

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Feb 6, 2024
@preda-bogdan preda-bogdan added the pr-checklist-skip Allow this Pull Request to skip checklist. label Feb 6, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Feb 6, 2024
@pirate-bot
Copy link
Collaborator

pirate-bot commented Feb 6, 2024

Plugin build for f307dbb is ready 🛎️!

Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For the failed E2E test, you can cherry-pick this commit 4ed1902 if re-running it does not work.

(cherry picked from commit 4ed1902)
@irinelenache
Copy link
Contributor

@preda-bogdan Tested and everything works fine, except for how the range controls look when Neve Pro is not active
https://vertis.d.pr/i/tcwyPY

@preda-bogdan
Copy link
Contributor Author

@irinelenache can you let me know what browser you used? Thank you!

@irinelenache
Copy link
Contributor

@preda-bogdan Chrome Version 121.0.6167.160 / macOS 12.2.1 / Built-in Liquid Retina XDR Display 14-inch (3024 × 1964)

I see the issue is visible also in the screenshot you provided

@preda-bogdan
Copy link
Contributor Author

@irinelenache Sorry for that, there was a typo in CSS that I introduced when changing the target. It should look correct now.
I also updated the screenshot.

@irinelenache
Copy link
Contributor

@preda-bogdan Everything's fine now, thank you 🚀

@preda-bogdan preda-bogdan merged commit 83d18c8 into development Feb 22, 2024
18 of 19 checks passed
@preda-bogdan preda-bogdan deleted the feat/scroll_to_top_cta branch February 22, 2024 13:19
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants