-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added scroll to top cta #4202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. For the failed E2E test, you can cherry-pick this commit 4ed1902 if re-running it does not work.
(cherry picked from commit 4ed1902)
@preda-bogdan Tested and everything works fine, except for how the range controls look when Neve Pro is not active |
@irinelenache can you let me know what browser you used? Thank you! |
@preda-bogdan Chrome Version 121.0.6167.160 / macOS 12.2.1 / Built-in Liquid Retina XDR Display 14-inch (3024 × 1964) I see the issue is visible also in the screenshot you provided |
@irinelenache Sorry for that, there was a typo in CSS that I introduced when changing the target. It should look correct now. |
@preda-bogdan Everything's fine now, thank you 🚀 |
🎉 This PR is included in version 3.8.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Added new upsell control for Scroll To Top CTA.
Will affect the visual aspect of the product
YES/NO
Screenshots
Neve Free Scroll To Top Upsell
Test instructions
Check before Pull Request is ready:
Closes Codeinwp/neve-pro-addon#2734.