Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid CSS syntax in nav-walker.php #4251

Closed
jankohoener opened this issue Jun 17, 2024 · 1 comment · Fixed by #4252
Closed

Invalid CSS syntax in nav-walker.php #4251

jankohoener opened this issue Jun 17, 2024 · 1 comment · Fixed by #4252
Assignees
@preda-bogdan
Labels
bug This label could be used to identify issues that are caused by a defect in the product. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.

Comments

@jankohoener
Copy link

Description

On line 231 the CSS syntax incorrectly uses a & (https://github.com/Codeinwp/neve/blob/master/inc/views/nav_walker.php#L231). This created a W3C Validation error for our site.

Step-by-step reproduction instructions

see desc

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No
@jankohoener jankohoener added the bug This label could be used to identify issues that are caused by a defect in the product. label Jun 17, 2024
@vytisbulkevicius vytisbulkevicius added the Priority-Medium Expected resolution time - up to 1 month. label Jun 19, 2024
@preda-bogdan preda-bogdan added the tiny (1h) - This label is used for issues that can be completed in under an hour. label Jun 19, 2024
preda-bogdan added a commit that referenced this issue Jun 19, 2024
@preda-bogdan
fix: solve css syntax #4251
8c8cc70
@preda-bogdan preda-bogdan mentioned this issue Jun 19, 2024
Merged
6 tasks
@preda-bogdan preda-bogdan linked a pull request Jun 19, 2024 that will close this issue
fix: solve css syntax #4252
Merged
6 tasks
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.8.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@preda-bogdan preda-bogdan

Labels
bug This label could be used to identify issues that are caused by a defect in the product. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: solve css syntax Codeinwp/neve
4 participants
@jankohoener @preda-bogdan @vytisbulkevicius @pirate-bot