Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumb NavXT integration is broken #4267

Closed
piit79 opened this issue Jul 5, 2024 · 4 comments · Fixed by #4272 or #4280
Closed

Breadcrumb NavXT integration is broken #4267

piit79 opened this issue Jul 5, 2024 · 4 comments · Fixed by #4272 or #4280
Labels
bug This label could be used to identify issues that are caused by a defect in the product. regression Issue represents a change in behavior from a previous version that is not intended or desired.. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@piit79
Copy link
Contributor

piit79 commented Jul 5, 2024

Description

Breadcrumb NavXT integration is not working properly. The rendering of Breadcrumb NavXT breadcrumbs was apparently removed in commit ee748ab (by mistake I assume).

Step-by-step reproduction instructions

  1. Install Breadcrumb NavXT
  2. Enable breadcrumbs in Breadcrumb NavXT
  3. Breadcrumbs are not rendered in Neve

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

Yes, this is a regression.
@piit79 piit79 added the bug This label could be used to identify issues that are caused by a defect in the product. label Jul 5, 2024
@pirate-bot pirate-bot added the regression Issue represents a change in behavior from a previous version that is not intended or desired.. label Jul 5, 2024
@selul
Copy link
Contributor

selul commented Jul 10, 2024

@piit79 thanks for reporting, we will look into it.

@piit79
Copy link
Contributor Author

piit79 commented Jul 10, 2024

Thanks! I thought I'd submit a PR - the fix itself is trivial (just reintroduce the code at the end of maybe_render_seo_breadcrumbs() that was removed by mistake), but the contrib guidelines call for adding a test and running all the tests etc. which of course is a good idea, but sadly too time consuming for me at the moment.

@selul
Copy link
Contributor

selul commented Jul 10, 2024

Hi, sure, feel free to send one without and I will have a look.
Thanks!

@piit79 piit79 mentioned this issue Jul 14, 2024
Merged
6 tasks
@selul selul mentioned this issue Jul 31, 2024
Merged
@vytisbulkevicius vytisbulkevicius linked a pull request Aug 14, 2024 that will close this issue
Development #4280
Merged
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.8.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This label could be used to identify issues that are caused by a defect in the product. regression Issue represents a change in behavior from a previous version that is not intended or desired.. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Breadcrumb NavXT breadcrumb rendering piit79/neve
Development Codeinwp/neve
3 participants
@piit79 @selul @pirate-bot