Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inappropriate use of !important in blockquote cite CSS #4273

Closed
poonam279 opened this issue Jul 16, 2024 · 1 comment
Closed

Inappropriate use of !important in blockquote cite CSS #4273

poonam279 opened this issue Jul 16, 2024 · 1 comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.

Comments

@poonam279
Copy link

Description

A user reported an issue with the CSS in the NEVE theme that interferes with their ability to use REM units. The specific CSS in question is:

blockquote cite {
    font-style: normal;
    font-size: .9em!important;
}

Using !important in this way limits customization and flexibility for users who wish to apply their own styles.

Step-by-step reproduction instructions

  1. Add a blockquote block to a page
  2. Apply custom CSS using REM units for the blockquote cite element.
  3. Notice that the custom styles are overridden by the existing !important rule.

Screenshots, screen recording, code snippet or Help Scout ticket

Screenshot: https://vertis.d.pr/i/Bcm42W

Environment info

No response

Is the issue you are reporting a regression

No

@poonam279 poonam279 added the bug This label could be used to identify issues that are caused by a defect in the product. label Jul 16, 2024
@selul
Copy link
Contributor

selul commented Jul 23, 2024

Yes, we can't really remove that right now without proper investigating of the effect. This can be easily fixed by user by adding a more specific selector, i.e it can be body blockquote cite or using some wrapper class.

@selul selul closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Projects
None yet
Development

No branches or pull requests

2 participants