From 6192c930fd748e99097578ba140f6a8bdbfd46fa Mon Sep 17 00:00:00 2001 From: "Soare Robert Daniel (Mac 2023)" Date: Fri, 8 Dec 2023 13:10:26 +0200 Subject: [PATCH 01/11] chore: use the same PHP version for Lint as in PHPStan --- .github/workflows/test-php.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-php.yml b/.github/workflows/test-php.yml index cf2b0809a7..a846c3277b 100644 --- a/.github/workflows/test-php.yml +++ b/.github/workflows/test-php.yml @@ -18,7 +18,7 @@ jobs: - name: Setup PHP version uses: shivammathur/setup-php@v2 with: - php-version: '7.1' + php-version: '7.4' extensions: simplexml tools: composer:v2.1 - name: Checkout source code From ae06c002daaa64fe13502e713c38d1b2802f7d5a Mon Sep 17 00:00:00 2001 From: "Soare Robert Daniel (Mac 2023)" Date: Fri, 8 Dec 2023 13:29:20 +0200 Subject: [PATCH 02/11] chore: make php7.4 as default for test-php.yml --- .github/workflows/test-php.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-php.yml b/.github/workflows/test-php.yml index a846c3277b..fd3ba1bc53 100644 --- a/.github/workflows/test-php.yml +++ b/.github/workflows/test-php.yml @@ -54,7 +54,7 @@ jobs: - name: Setup PHP version uses: shivammathur/setup-php@v2 with: - php-version: '7.1' + php-version: '7.4' extensions: simplexml, mysql tools: phpunit-polyfills - name: Checkout source code From c42315ed1a1a345089a405d10ec895aba9fbd464 Mon Sep 17 00:00:00 2001 From: "Soare Robert Daniel (Mac 2023)" Date: Fri, 8 Dec 2023 14:02:28 +0200 Subject: [PATCH 03/11] chore: update test --- tests/test-neve-dynamic-selector.php | 48 ++++++++++++++-------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/tests/test-neve-dynamic-selector.php b/tests/test-neve-dynamic-selector.php index eef2ee9b02..d13e698a97 100644 --- a/tests/test-neve-dynamic-selector.php +++ b/tests/test-neve-dynamic-selector.php @@ -33,7 +33,7 @@ public function test_css_generation_with_color() { $css = ''; $css .= $subscriber; $this->assertNotEmpty( $css ); - $this->assertContains( "#ccc", $css ); + $this->assertStringContainsString( "#ccc", $css ); } public function test_css_generation_with_generic_rule() { @@ -45,7 +45,7 @@ public function test_css_generation_with_generic_rule() { ] ); $css = ''; $css .= $subscriber; - $this->assertContains('--css-var-example', $css); + $this->assertStringContainsString('--css-var-example', $css); $this->assertNotEmpty( $css ); } @@ -65,7 +65,7 @@ public function test_css_generation_with_value_override() { $this->assertNotEmpty( $css ); $this->assertNotContains( "#bada55", $css ); - $this->assertContains( "var(--nv-text-color)", $css ); + $this->assertStringContainsString( "var(--nv-text-color)", $css ); } public function test_css_generation_with_key() { @@ -81,7 +81,7 @@ public function test_css_generation_with_key() { $css .= $subscriber; $this->assertNotEmpty( $css ); - $this->assertContains( "#eee", $css ); + $this->assertStringContainsString( "#eee", $css ); } public function test_css_generation_with_suffix() { @@ -98,7 +98,7 @@ public function test_css_generation_with_suffix() { $css .= $subscriber; $this->assertNotEmpty( $css ); - $this->assertContains( "333em", $css ); + $this->assertStringContainsString( "333em", $css ); } public function test_css_generation_with_default() { @@ -113,7 +113,7 @@ public function test_css_generation_with_default() { $css = ''; $css .= $subscriber; $this->assertNotEmpty( $css ); - $this->assertContains( "929", $css ); + $this->assertStringContainsString( "929", $css ); } public function test_css_generation_with_filter() { @@ -132,7 +132,7 @@ public function test_css_generation_with_filter() { $css = ''; $css .= $subscriber; $this->assertNotEmpty( $css ); - $this->assertContains( "box-shadow: 333px;", $css ); + $this->assertStringContainsString( "box-shadow: 333px;", $css ); } public function test_css_generation_on_breakpoints() { @@ -149,7 +149,7 @@ public function test_css_generation_on_breakpoints() { $tablet_css = '' . $subscriber->for_tablet(); $this->assertNotEmpty( $mobile_css ); - $this->assertContains( "929", $mobile_css ); + $this->assertStringContainsString( "929", $mobile_css ); $this->assertEmpty( $desktop_css ); $this->assertEmpty( $tablet_css ); } @@ -172,9 +172,9 @@ public function test_css_generation_with_responsive() { $mobile_css = '' . $subscriber; $desktop_css = '' . $subscriber->for_desktop(); $tablet_css = '' . $subscriber->for_tablet(); - $this->assertContains( "10px;", $mobile_css ); - $this->assertContains( "50px;", $desktop_css ); - $this->assertContains( "300px;", $tablet_css ); + $this->assertStringContainsString( "10px;", $mobile_css ); + $this->assertStringContainsString( "50px;", $desktop_css ); + $this->assertStringContainsString( "300px;", $tablet_css ); } public function test_css_generation_with_responsiveness_encoded() { @@ -194,9 +194,9 @@ public function test_css_generation_with_responsiveness_encoded() { $mobile_css = '' . $subscriber; $desktop_css = '' . $subscriber->for_desktop(); $tablet_css = '' . $subscriber->for_tablet(); - $this->assertContains( "10px;", $mobile_css ); - $this->assertContains( "50px;", $desktop_css ); - $this->assertContains( "300px;", $tablet_css ); + $this->assertStringContainsString( "10px;", $mobile_css ); + $this->assertStringContainsString( "50px;", $desktop_css ); + $this->assertStringContainsString( "300px;", $tablet_css ); } public function test_css_generation_with_responsiveness_no_devices() { @@ -212,9 +212,9 @@ public function test_css_generation_with_responsiveness_no_devices() { $mobile_css = '' . $subscriber; $desktop_css = '' . $subscriber->for_desktop(); $tablet_css = '' . $subscriber->for_tablet(); - $this->assertContains( "200px;", $mobile_css ); - $this->assertContains( "200px;", $desktop_css ); - $this->assertContains( "200px;", $tablet_css ); + $this->assertStringContainsString( "200px;", $mobile_css ); + $this->assertStringContainsString( "200px;", $desktop_css ); + $this->assertStringContainsString( "200px;", $tablet_css ); } public function test_css_generation_responsiveness_with_subkey() { @@ -236,9 +236,9 @@ public function test_css_generation_responsiveness_with_subkey() { $mobile_css = '' . $subscriber; $desktop_css = '' . $subscriber->for_desktop(); $tablet_css = '' . $subscriber->for_tablet(); - $this->assertContains( "555px;", $mobile_css ); - $this->assertContains( "666px;", $desktop_css ); - $this->assertContains( "777px;", $tablet_css ); + $this->assertStringContainsString( "555px;", $mobile_css ); + $this->assertStringContainsString( "666px;", $desktop_css ); + $this->assertStringContainsString( "777px;", $tablet_css ); } public function test_css_generation_responsiveness_with_subkey_with_suffix() { @@ -265,9 +265,9 @@ public function test_css_generation_responsiveness_with_subkey_with_suffix() { $mobile_css = '' . $subscriber; $desktop_css = '' . $subscriber->for_desktop(); $tablet_css = '' . $subscriber->for_tablet(); - $this->assertContains( "555em;", $mobile_css ); - $this->assertContains( "666%;", $desktop_css ); - $this->assertContains( "777px;", $tablet_css ); + $this->assertStringContainsString( "555em;", $mobile_css ); + $this->assertStringContainsString( "666%;", $desktop_css ); + $this->assertStringContainsString( "777px;", $tablet_css ); } public function test_css_generation_with_extra_selectors() { @@ -286,7 +286,7 @@ public function test_css_generation_with_extra_selectors() { $css = '' . $subscriber; $this->assertContains( ",.one-test-selector", $css ); - $this->assertNotContains( \Neve\Core\Settings\Config::CSS_SELECTOR_BTN_PRIMARY_HOVER, $css ); + $this->assertStringContainsString( \Neve\Core\Settings\Config::CSS_SELECTOR_BTN_PRIMARY_HOVER, $css ); $this->assertContains( "color: #fff", $css ); } } From 8cd32b2ecec1a9704c9e485fd9e7986187b8f97b Mon Sep 17 00:00:00 2001 From: "Soare Robert Daniel (Mac 2023)" Date: Fri, 8 Dec 2023 14:05:32 +0200 Subject: [PATCH 04/11] chore: update test --- tests/test-neve-dynamic-selector.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test-neve-dynamic-selector.php b/tests/test-neve-dynamic-selector.php index d13e698a97..9fae98a849 100644 --- a/tests/test-neve-dynamic-selector.php +++ b/tests/test-neve-dynamic-selector.php @@ -64,7 +64,7 @@ public function test_css_generation_with_value_override() { $css .= $subscriber; $this->assertNotEmpty( $css ); - $this->assertNotContains( "#bada55", $css ); + $this->assertStringNotContainsString( "#bada55", $css ); $this->assertStringContainsString( "var(--nv-text-color)", $css ); } @@ -285,8 +285,8 @@ public function test_css_generation_with_extra_selectors() { ] ); $css = '' . $subscriber; - $this->assertContains( ",.one-test-selector", $css ); + $this->assertStringContainsString( ",.one-test-selector", $css ); $this->assertStringContainsString( \Neve\Core\Settings\Config::CSS_SELECTOR_BTN_PRIMARY_HOVER, $css ); - $this->assertContains( "color: #fff", $css ); + $this->assertStringContainsString( "color: #fff", $css ); } } From ee4cf5fc4fe4e35f46687fa27d6f0ee8eeebcbab Mon Sep 17 00:00:00 2001 From: "Soare Robert Daniel (Mac 2023)" Date: Fri, 8 Dec 2023 14:26:59 +0200 Subject: [PATCH 05/11] fix: incorect usage of selector mapping in testing --- tests/test-neve-dynamic-selector.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-neve-dynamic-selector.php b/tests/test-neve-dynamic-selector.php index 9fae98a849..7a50a385aa 100644 --- a/tests/test-neve-dynamic-selector.php +++ b/tests/test-neve-dynamic-selector.php @@ -286,7 +286,7 @@ public function test_css_generation_with_extra_selectors() { $css = '' . $subscriber; $this->assertStringContainsString( ",.one-test-selector", $css ); - $this->assertStringContainsString( \Neve\Core\Settings\Config::CSS_SELECTOR_BTN_PRIMARY_HOVER, $css ); + $this->assertStringContainsString( \Neve\Core\Settings\Config::$css_selectors_map[\Neve\Core\Settings\Config::CSS_SELECTOR_BTN_PRIMARY_HOVER], $css ); $this->assertStringContainsString( "color: #fff", $css ); } } From 46c7582a516d9998b440106fe73535b1c7d043a6 Mon Sep 17 00:00:00 2001 From: "Soare Robert Daniel (Mac 2023)" Date: Fri, 8 Dec 2023 14:46:43 +0200 Subject: [PATCH 06/11] fix: re-add test --- tests/test-neve-dynamic-selector.php | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-neve-dynamic-selector.php b/tests/test-neve-dynamic-selector.php index 7a50a385aa..82be8fddf7 100644 --- a/tests/test-neve-dynamic-selector.php +++ b/tests/test-neve-dynamic-selector.php @@ -286,6 +286,7 @@ public function test_css_generation_with_extra_selectors() { $css = '' . $subscriber; $this->assertStringContainsString( ",.one-test-selector", $css ); + $this->assertStringNotContainsString( \Neve\Core\Settings\Config::CSS_SELECTOR_BTN_PRIMARY_HOVER, $css ); $this->assertStringContainsString( \Neve\Core\Settings\Config::$css_selectors_map[\Neve\Core\Settings\Config::CSS_SELECTOR_BTN_PRIMARY_HOVER], $css ); $this->assertStringContainsString( "color: #fff", $css ); } From 42a79d03b3171a761a63c2c02e43c63591e432d4 Mon Sep 17 00:00:00 2001 From: Bogdan Preda Date: Wed, 13 Dec 2023 11:55:14 +0200 Subject: [PATCH 07/11] fix: woo block checkout cupon button Codeinwp/neve-pro-addon#2697 --- assets/scss/components/compat/woocommerce/_checkout.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/scss/components/compat/woocommerce/_checkout.scss b/assets/scss/components/compat/woocommerce/_checkout.scss index f6b6696bf5..af210cff56 100644 --- a/assets/scss/components/compat/woocommerce/_checkout.scss +++ b/assets/scss/components/compat/woocommerce/_checkout.scss @@ -144,7 +144,7 @@ border: 0 !important; } - main button { + main button:not(.wc-block-components-button) { width: 100%; } } From 388f8d7485c81c7633030ed39b610bd5c0efd758 Mon Sep 17 00:00:00 2001 From: "Soare Robert Daniel (Mac 2023)" Date: Thu, 14 Dec 2023 15:08:13 +0200 Subject: [PATCH 08/11] fix: make woo breadcrumps scrollable --- .../scss/components/compat/woocommerce/_breadcrumbs.scss | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/assets/scss/components/compat/woocommerce/_breadcrumbs.scss b/assets/scss/components/compat/woocommerce/_breadcrumbs.scss index a76a804ff2..347c9fc45e 100644 --- a/assets/scss/components/compat/woocommerce/_breadcrumbs.scss +++ b/assets/scss/components/compat/woocommerce/_breadcrumbs.scss @@ -4,6 +4,13 @@ color: var(--nv-text-color); font-size: 14px; white-space: nowrap; + scrollbar-width: none; /* Firefox */ + overflow-x: scroll; + + &::-webkit-scrollbar { + display: none; /* Chrome, Safari, Opera*/ + } + a { color: var(--nv-secondary-accent); From 52fe7780ac74c9566053d5f1bf15754b08d6a633 Mon Sep 17 00:00:00 2001 From: GrigoreMihai Date: Thu, 14 Dec 2023 23:34:44 +0200 Subject: [PATCH 09/11] fix: alignment of secondary menu on mobile #4015 --- inc/views/nav_walker.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc/views/nav_walker.php b/inc/views/nav_walker.php index 76aaf5f50f..f108cf7d75 100644 --- a/inc/views/nav_walker.php +++ b/inc/views/nav_walker.php @@ -209,7 +209,7 @@ public function get_mobile_caret_style() { $mobile_button_caret_css .= '.header-menu-sidebar .nav-ul li .wrap a { flex-grow: 1; display: flex; }'; $mobile_button_caret_css .= '.header-menu-sidebar .nav-ul li .wrap a .dd-title { width: var(--wrapdropdownwidth); }'; $mobile_button_caret_css .= '.header-menu-sidebar .nav-ul li .wrap button { border: 0; z-index: 1; background: 0; }'; - $mobile_button_caret_css .= '.header-menu-sidebar .nav-ul li:not([class*=block]):not(.menu-item-has-children) > .wrap > a { padding-right: calc(1em + (18px*2));}'; + $mobile_button_caret_css .= '.header-menu-sidebar .nav-ul li.menu-item-has-children:not([class*=block]) > .wrap > a { margin-right: calc(-1em - (18px*2));}'; return Dynamic_Css::minify_css( $mobile_button_caret_css ); } From 4e085f4e6e84689f825346996f663bd1309fbed2 Mon Sep 17 00:00:00 2001 From: "themeisle[bot]" Date: Mon, 18 Dec 2023 00:12:55 +0000 Subject: [PATCH 10/11] chore: Update Google fonts --- globals/google-fonts.php | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/globals/google-fonts.php b/globals/google-fonts.php index c4b443b2c7..732aed729a 100644 --- a/globals/google-fonts.php +++ b/globals/google-fonts.php @@ -1,6 +1,6 @@ array( '400',), 'Harmattan' => array( '400', '500', '600', '700',), 'Headland One' => array( '400',), + 'Hedvig Letters Sans' => array( '400',), + 'Hedvig Letters Serif' => array( '400',), 'Heebo' => array( '100', '200', '300', '400', '500', '600', '700', '800', '900',), 'Henny Penny' => array( '400',), 'Hepta Slab' => array( '100', '200', '300', '400', '500', '600', '700', '800', '900',), @@ -899,7 +901,7 @@ 'Nanum Gothic Coding' => array( '400', '700',), 'Nanum Myeongjo' => array( '400', '700', '800',), 'Nanum Pen Script' => array( '400',), - 'Narnoor' => array( '400',), + 'Narnoor' => array( '400', '500', '600', '700', '800',), 'Neonderthaw' => array( '400',), 'Nerko One' => array( '400',), 'Neucha' => array( '400',), @@ -1316,13 +1318,18 @@ 'Rubik' => array( '300', '400', '500', '600', '700', '800', '900', '300italic', '400italic', '500italic', '600italic', '700italic', '800italic', '900italic',), 'Rubik 80s Fade' => array( '400',), 'Rubik Beastly' => array( '400',), + 'Rubik Broken Fax' => array( '400',), 'Rubik Bubbles' => array( '400',), 'Rubik Burned' => array( '400',), 'Rubik Dirt' => array( '400',), 'Rubik Distressed' => array( '400',), + 'Rubik Doodle Shadow' => array( '400',), + 'Rubik Doodle Triangles' => array( '400',), 'Rubik Gemstones' => array( '400',), 'Rubik Glitch' => array( '400',), 'Rubik Iso' => array( '400',), + 'Rubik Lines' => array( '400',), + 'Rubik Maps' => array( '400',), 'Rubik Marker Hatch' => array( '400',), 'Rubik Maze' => array( '400',), 'Rubik Microbe' => array( '400',), @@ -1330,6 +1337,7 @@ 'Rubik Moonrocks' => array( '400',), 'Rubik Pixels' => array( '400',), 'Rubik Puddles' => array( '400',), + 'Rubik Scribble' => array( '400',), 'Rubik Spray Paint' => array( '400',), 'Rubik Storm' => array( '400',), 'Rubik Vinyl' => array( '400',), From c333dc9072f11f0c270e78abef36eb1d9bb07c09 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 18 Dec 2023 17:22:11 +0000 Subject: [PATCH 11/11] chore(deps): bump codeinwp/themeisle-sdk from 3.3.9 to 3.3.11 Bumps [codeinwp/themeisle-sdk](https://github.com/Codeinwp/themeisle-sdk) from 3.3.9 to 3.3.11. - [Release notes](https://github.com/Codeinwp/themeisle-sdk/releases) - [Changelog](https://github.com/Codeinwp/themeisle-sdk/blob/master/CHANGELOG.md) - [Commits](https://github.com/Codeinwp/themeisle-sdk/compare/v3.3.9...v3.3.11) --- updated-dependencies: - dependency-name: codeinwp/themeisle-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- composer.lock | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/composer.lock b/composer.lock index a6fbb2741e..c0aa98ea00 100644 --- a/composer.lock +++ b/composer.lock @@ -8,16 +8,16 @@ "packages": [ { "name": "codeinwp/themeisle-sdk", - "version": "3.3.9", + "version": "3.3.11", "source": { "type": "git", "url": "https://github.com/Codeinwp/themeisle-sdk.git", - "reference": "d960c559b643f468d16ffc5379e83efdb1526224" + "reference": "583c474d8b5a8d12592f4a78ab8fa335aaf42fc0" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/Codeinwp/themeisle-sdk/zipball/d960c559b643f468d16ffc5379e83efdb1526224", - "reference": "d960c559b643f468d16ffc5379e83efdb1526224", + "url": "https://api.github.com/repos/Codeinwp/themeisle-sdk/zipball/583c474d8b5a8d12592f4a78ab8fa335aaf42fc0", + "reference": "583c474d8b5a8d12592f4a78ab8fa335aaf42fc0", "shasum": "" }, "require-dev": { @@ -42,9 +42,9 @@ ], "support": { "issues": "https://github.com/Codeinwp/themeisle-sdk/issues", - "source": "https://github.com/Codeinwp/themeisle-sdk/tree/v3.3.9" + "source": "https://github.com/Codeinwp/themeisle-sdk/tree/v3.3.11" }, - "time": "2023-11-16T15:27:37+00:00" + "time": "2023-12-12T10:06:27+00:00" }, { "name": "wptt/webfont-loader",