Apps not removed due to dependencies, marked as removed without user warning

[pabloyoyoista]

EDIT: The text below is the original issue. Real problem is that removing apps that are not removed due to dependencies seems to succeed while the app is not removed. In the CLI, it prints information useful for the user. See #10 (comment)

Trying to uninstall an installed application from gnome-software 41 removed the application from the graphical view, but did not really uninstall the app.

An extract of the log and then verification that the app is not uninstalled. Running with G_MESSAGES_DEBUG=all:

20:22:20:0571 Gs  uninstall org.gnome.Nautilus.desktop
20:22:20:0571 Gs  Chaining cancellation from 0xffff7bce09e0 to 0xffff6af5f360
20:22:20:0572 GsPluginApk Trying to remove app system/package/alpinelinux-edge-community/org.gnome.Nautilus.desktop/*

(phosh:3167): GLib-GObject-CRITICAL **: 21:22:20.582: g_object_set_data: assertion 'G_IS_OBJECT (object)' failed
20:22:20:0877 Gs  Looking for icon for org.gnome.Nautilus.desktop, at size 64×2, with fallback system-component-application
20:22:20:0877 Gs        Considering icon of type GFileIcon (/var/cache/app-info/icons/alpinelinux-edge-community/64x64/nautilus_org.gnome.Nautilus.png), width 64×1
20:22:20:0877 Gs        Considering icon of type GThemedIcon (org.gnome.Nautilus), width 0×1
20:22:20:0877 Gs  Found no icons of the right size; checking themed icons
20:22:22:0861 Gs  plugin apk took 2.3 seconds to do remove
20:22:22:0868 GsPluginApk Starting refinining process
20:22:23:0122 Gs  Looking for icon for org.gnome.Nautilus.desktop, at size 64×2, with fallback system-component-application
20:22:23:0122 Gs        Considering icon of type GFileIcon (/var/cache/app-info/icons/alpinelinux-edge-community/64x64/nautilus_org.gnome.Nautilus.png), width 64×1
20:22:23:0122 Gs        Considering icon of type GThemedIcon (org.gnome.Nautilus), width 0×1
20:22:23:0123 Gs  Found no icons of the right size; checking themed icons
20:22:24:0766 GsPluginApk Found matching apk package nautilus for app system/package/alpinelinux-edge-community/org.gnome.Nautilus.desktop/*
20:22:24:0766 Gs  automatically prevented from changing origin on system/package/alpinelinux-edge-community/org.gnome.Nautilus.desktop/* from alpinelinux-edge-community to alpine!
20:22:24:0766 GsPluginApk State for pkg system/package/alpinelinux-edge-community/org.gnome.Nautilus.desktop/*: 1
20:22:24:0766 Gs  State change on system/package/alpinelinux-edge-community/org.gnome.Nautilus.desktop/* from available to installed is not OK
20:22:24:0766 Gs  plugin apk took 1.9 seconds to do refine
20:22:24:0767 Gs  running remove on plugin=apk with dedupe-flags=7 with refine-flags=require-setup-action,require-origin with interactive=True with timeout=60 on apps system/package/alpinelinux-edge-community/org.gnome.Nautilus.desktop/*, elapsed time since creation 4195ms
20:22:24:0767 Gs  Disconnecting cancellable 0xffff7bce09e0
^C
pine64-pinephone:~/41.1$ apk list nautilus
nautilus-41.0-r0 aarch64 {nautilus} (GPL-2.0-or-later) [installed]

[Cogitri]

(phosh:3167): GLib-GObject-CRITICAL **: 21:22:20.582: g_object_set_data: assertion 'G_IS_OBJECT (object)' failed is properly the point where it trips over. Could you run g-s in a debugger and set G_DEBUG=fatal-criticals? Then it should run into a breakpoint when that critical happens.

[pabloyoyoista]

Thanks a lot for the suggestion. It was not exactly that the problem, but it helped in the process. The problem in this case is that nautilus in my system cannot be removed:

$ sudo apk del nautilus
World update, but the following packages are not removed due to:
    nautilus: evince-nautilus evince kgx

Removing apps which can be removed is actually working fine. I guess the right behavior would be to fail the removal and notice users about the reason why it wasn't remove. I guess this is quite low priority though.

[Cogitri]

Yeah, even so we should at least fix the critical, since this could lead to other crashes/undefined behavior down the line.

[pabloyoyoista]

The log I pasted is from the display manager log. I believe it is related to the creation of a window dialog, so in principle it is totally unrelated to the plugin in this case.

[Cogitri]

Oh true, somehow I completely missed the phosh in front of that :)