Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

'watch' doesn't handle non-Status errors properly #2

Open
ankon opened this issue May 19, 2017 · 1 comment
Open

'watch' doesn't handle non-Status errors properly #2

ankon opened this issue May 19, 2017 · 1 comment

Comments

@ankon
Copy link
Contributor

ankon commented May 19, 2017

npm info it worked if it ends with ok
npm info using [email protected]
npm info using [email protected]
npm info lifecycle [email protected]~prestart: [email protected]
npm info lifecycle [email protected]~start: [email protected]

> [email protected] start /app
> node src/index.js "--namespace=development"

[2017-05-19 14:58:45.004] [INFO] [default] - Watching queues at 0...
undefined:1
Forbidden: "/apis/aws.k8s.collaborne.com/v1/namespaces/development/queues?watch=true&resourceVersion=0"
^

SyntaxError: Unexpected token F in JSON at position 0
    at Object.parse (native)
    at DestroyableTransform._flush (/app/node_modules/auto-kubernetes-client/src/index.js:144:24)
    at DestroyableTransform.<anonymous> (/app/node_modules/readable-stream/lib/_stream_transform.js:115:49)
    at DestroyableTransform.g (events.js:291:16)
    at emitNone (events.js:86:13)
    at DestroyableTransform.emit (events.js:185:7)
    at prefinish (/app/node_modules/readable-stream/lib/_stream_writable.js:494:12)
    at finishMaybe (/app/node_modules/readable-stream/lib/_stream_writable.js:506:7)
    at endWritable (/app/node_modules/readable-stream/lib/_stream_writable.js:514:3)
    at DestroyableTransform.Writable.end (/app/node_modules/readable-stream/lib/_stream_writable.js:484:41)

This is similar to d037e91, where it was fixed for non-watch resources.

@ankon
Copy link
Contributor Author

ankon commented May 19, 2017

Note that we should be checking the error code as well -- it seems we're just assuming that the response will be in json-stream format and is always successful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant