Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Leaks in TapPublisher #68

Open
DispoKen opened this issue Mar 4, 2022 · 3 comments
Open

Memory Leaks in TapPublisher #68

DispoKen opened this issue Mar 4, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@DispoKen
Copy link

DispoKen commented Mar 4, 2022

Describe the bug
We seems to be getting memory leaks with TapPublisher.

To Reproduce
Steps to reproduce the behavior:
Add a tapPublisher on a tapRecognizer
Expected behavior
No Memory Leaks

Screenshots

Screen Shot 2022-03-03 at 9 27 13 PM

Screen Shot 2022-03-03 at 9 32 38 PM

Screen Shot 2022-03-03 at 9 32 47 PM

Device:

  • Device: [e.g. iPhone X]
  • CombineCocoa version 0.4.0

Additional context
None
@DispoKen DispoKen added the bug Something isn't working label Mar 4, 2022
@kkizlaitis
Copy link

I have encountered this (or very similar) issue as well. There are lots of _UIBarButtonItems who seem to have a strong reference to UITapGestureRecognizer. The key thing is that the issue appears even when not using the library. If I just add CombineCocoa as a dependency in Cocoapods, the leaks happen. If I remove the dependency from Cocoapods, the leaks are gone.

@freak4pc
Copy link
Member

Can you please drop a reproducible project here? Thanks!

@brannpark
Copy link

Any updates for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@freak4pc @brannpark @kkizlaitis @DispoKen